Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #2563 - Fixes status change instructions #2598

Merged
merged 1 commit into from
Sep 25, 2018

Conversation

hritvi
Copy link
Contributor

@hritvi hritvi commented Sep 25, 2018

This PR fixes issue #2563
r? @laghee

@TravisBuddy
Copy link

Travis tests have failed

Hey @hritvi,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

1st Build

View build log

nosetests
Milestones are not initialized. Check logs.
npm run test:js -- --reporters="runner" --firefoxBinary=`which firefox`
> webcompat@ test:js /home/travis/build/webcompat/webcompat.com
> node ./tests/functional/_intern.js "--reporters=runner" "--firefoxBinary=/home/travis/firefox-latest/firefox/firefox"

Error: 
        ======================================================
        Intern checkServer Connection Error: Error: connect ECONNREFUSED 127.0.0.1:5000
        ======================================================
        
  at ClientRequest.<anonymous>  <tests/functional/lib/setup.js:55:9>
  at emitOne  <events.js:116:13>
  at ClientRequest.emit  <events.js:211:7>
  at Socket.socketErrorListener  <_http_client.js:387:9>
  at emitOne  <events.js:116:13>
  at Socket.emit  <events.js:211:7>
  at emitErrorNT  <internal/streams/destroy.js:64:8>
something bad happened inside intern.run()
{ Error: 
        ======================================================
        Intern checkServer Connection Error: Error: connect ECONNREFUSED 127.0.0.1:5000
        ======================================================
        
    at ClientRequest.<anonymous> (/home/travis/build/webcompat/webcompat.com/tests/functional/lib/setup.js:55:9)
    at emitOne (events.js:116:13)
    at ClientRequest.emit (events.js:211:7)
    at Socket.socketErrorListener (_http_client.js:387:9)
    at emitOne (events.js:116:13)
    at Socket.emit (events.js:211:7)
    at emitErrorNT (internal/streams/destroy.js:64:8)
    at _combinedTickCallback (internal/process/next_tick.js:138:11)
    at process._tickCallback (internal/process/next_tick.js:180:9) reported: true }
npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR! webcompat@ test:js: `node ./tests/functional/_intern.js "--reporters=runner" "--firefoxBinary=/home/travis/firefox-latest/firefox/firefox"`
npm ERR! Exit status 1
npm ERR! 
npm ERR! Failed at the webcompat@ test:js script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.

npm ERR! A complete log of this run can be found in:
npm ERR!     /home/travis/.npm/_logs/2018-09-25T09_28_25_018Z-debug.log
TravisBuddy Request Identifier: 6370bdf0-c0a5-11e8-baa7-8ff80113b6c0

Copy link
Contributor

@laghee laghee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @hritvi! This looks great. Do remember next time to change the PR title to start with "Fixes" (not just the commit message) so it closes out the issue automatically, though. (I changed it for you here.)

(see step 9: https://github.com/webcompat/webcompat.com/blob/master/docs/pr-coding-guidelines.md)

@laghee laghee changed the title Issue #2563-Fixes status change instructions Fixes #2563-Fixes status change instructions Sep 25, 2018
@laghee
Copy link
Contributor

laghee commented Sep 25, 2018

@miketaylr Had to kick Travis -- looks like it was just the milestone thing. It actually looks like it's letting me merge... So I'm going to try it! :sad_there's_no_power_glove_in_github_emojis

@laghee laghee merged commit 430616b into webcompat:master Sep 25, 2018
@laghee laghee changed the title Fixes #2563-Fixes status change instructions Fixes #2563 - Fixes status change instructions Sep 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants