Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #2552 - Adds additional csp directives #2553

Merged
merged 1 commit into from
Jul 17, 2018

Conversation

laghee
Copy link
Contributor

@laghee laghee commented Jul 12, 2018

This PR fixes issue #2552

Proposed PR background

This pull request restricts frame-ancestors, base-uri, and form-action in the content security policy to self for a small enhancement to security.


@laghee laghee requested a review from miketaylr July 12, 2018 15:12
@TravisBuddy
Copy link

TravisBuddy commented Jul 12, 2018

Travis tests have failed

Hey @laghee,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

@laghee
Copy link
Contributor Author

laghee commented Jul 12, 2018

Sighhhhhh ... #2518

@miketaylr
Copy link
Member

Sighhhhhh ... #2518

just had to re-kick travis, tests are passing now.

Copy link
Member

@miketaylr miketaylr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r+

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants