Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes #2517 - Fixes typo in SVG markup #2523

Merged
merged 1 commit into from
Jun 25, 2018

Conversation

patrickkettner
Copy link
Contributor

No description provided.

@patrickkettner patrickkettner changed the title fix type fix typo Jun 23, 2018
@TravisBuddy
Copy link

Travis tests have failed

Hey @patrickkettner,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

1st Build

npm run test:js -- --reporters="runner" --firefoxBinary=`which firefox`
> webcompat@ test:js /home/travis/build/webcompat/webcompat.com
> node ./tests/functional/_intern.js "--reporters=runner" "--firefoxBinary=/home/travis/firefox-58.0/firefox/firefox"

Error: 
        ======================================================
        Oops, something went wrong. Try restarting the server.
        Open another terminal and window type:
        npm run start:test
        or
        python run.py -t
        ======================================================
        
  at ClientRequest.<anonymous>  <tests/functional/lib/setup.js:55:9>
  at emitOne  <events.js:116:13>
  at ClientRequest.emit  <events.js:211:7>
  at Socket.socketErrorListener  <_http_client.js:387:9>
  at emitOne  <events.js:116:13>
  at Socket.emit  <events.js:211:7>
  at emitErrorNT  <internal/streams/destroy.js:64:8>
something bad happened inside intern.run()
{ Error: 
        ======================================================
        Oops, something went wrong. Try restarting the server.
        Open another terminal and window type:
        npm run start:test
        or
        python run.py -t
        ======================================================
        
    at ClientRequest.<anonymous> (/home/travis/build/webcompat/webcompat.com/tests/functional/lib/setup.js:55:9)
    at emitOne (events.js:116:13)
    at ClientRequest.emit (events.js:211:7)
    at Socket.socketErrorListener (_http_client.js:387:9)
    at emitOne (events.js:116:13)
    at Socket.emit (events.js:211:7)
    at emitErrorNT (internal/streams/destroy.js:64:8)
    at _combinedTickCallback (internal/process/next_tick.js:138:11)
    at process._tickCallback (internal/process/next_tick.js:180:9) reported: true }
npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR! webcompat@ test:js: `node ./tests/functional/_intern.js "--reporters=runner" "--firefoxBinary=/home/travis/firefox-58.0/firefox/firefox"`
npm ERR! Exit status 1
npm ERR! 
npm ERR! Failed at the webcompat@ test:js script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.

npm ERR! A complete log of this run can be found in:
npm ERR!     /home/travis/.npm/_logs/2018-06-23T00_33_21_936Z-debug.log

@zoepage
Copy link
Member

zoepage commented Jun 25, 2018

That's a nice catch! Thanks :)
As we always have an issue for every pr, I created one and changed the title to fit our conventions.

Would you be able to change the commit message to something like "Issue #2524 - fix typo", so it shows up in the logs correctly? Ty! ♥️

@zoepage zoepage changed the title fix typo fixes #2524 - fix typo Jun 25, 2018
@magsout
Copy link
Member

magsout commented Jun 25, 2018

@zoepage the PR fixes this issue #2517 ? isn't it ?

@karlcow karlcow changed the title fixes #2524 - fix typo fixes #2517 - Fixes typo in SVG markup Jun 25, 2018
@zoepage
Copy link
Member

zoepage commented Jun 25, 2018

It does! This happens when you check the GH messages on your commute 😅 thanks you two!

@miketaylr miketaylr self-requested a review June 25, 2018 15:32
Copy link
Member

@miketaylr miketaylr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @patrickkettner!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants