Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #2493. Update some npm deps. #2495

Merged
merged 6 commits into from
Jun 18, 2018
Merged

Fixes #2493. Update some npm deps. #2495

merged 6 commits into from
Jun 18, 2018

Conversation

miketaylr
Copy link
Member

No description provided.

@miketaylr miketaylr requested a review from magsout June 13, 2018 23:51
@miketaylr
Copy link
Member Author

r? @magsout

Is there anything scary about these major version bumps related to postcss?

Locally, gruntcss is working, and tests are passing on Travis... but there might be some differences I'm not observing?

@magsout
Copy link
Member

magsout commented Jun 14, 2018

@miketaylr no worries, #2314 (comment)

So you can be confident with this major updated.

What I did:

git fetch origin
git checkout -b issues/2493/1 origin/issues/2493/1
rm -Rf node_modules
npm install
npm run start

No errors in terminal, and site looks good .

r + @miketaylr

I let you merge because of the label you putted

@miketaylr
Copy link
Member Author

Thanks @magsout!

@miketaylr miketaylr merged commit 010279c into master Jun 18, 2018
@miketaylr miketaylr deleted the issues/2493/1 branch June 18, 2018 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants