Fixes #2483. Markup fixes (SVG alternatives, invalid code, unnecessary role="button", account dropdown trigger)

[patrickhlauke]

Issue #2483 - fixes incorrect/unnecessary SVG alternative text, removes invalid aria-role="hide", removes unnecessary role="button" on <button> elements, fixes up the currently broken aria on the account dropdown trigger

r? @miketaylr

• [x ] I have read the Pull Request + Code Style Guidelines thoroughly.

[patrickhlauke]

worth noting: i did not try to compile/run the site locally, just edited the files "dry"

[TravisBuddy]

Travis tests have failed

Hey @patrickhlauke,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

1st Build

nosetests

Milestones are not initialized. Check logs.

travis_time:end:2ac19c68:start=1528280266118711862,finish=1528280266984126877,duration=865415015

npm run test:js -- --reporters="runner" --firefoxBinary=`which firefox`

> webcompat@ test:js /home/travis/build/webcompat/webcompat.com
> node ./tests/functional/_intern.js "--reporters=runner" "--firefoxBinary=/home/travis/firefox-58.0/firefox/firefox"

Error: 
        ======================================================
        Oops, something went wrong. Try restarting the server.
        Open another terminal and window type:
        npm run start:test
        or
        python run.py -t
        ======================================================
        
  at ClientRequest.<anonymous>  <tests/functional/lib/setup.js:55:9>
  at emitOne  <events.js:116:13>
  at ClientRequest.emit  <events.js:211:7>
  at Socket.socketErrorListener  <_http_client.js:387:9>
  at emitOne  <events.js:116:13>
  at Socket.emit  <events.js:211:7>
  at emitErrorNT  <internal/streams/destroy.js:64:8>
{ Error: 
        ======================================================
        Oops, something went wrong. Try restarting the server.
        Open another terminal and window type:
        npm run start:test
        or
        python run.py -t
        ======================================================
        
    at ClientRequest.<anonymous> (/home/travis/build/webcompat/webcompat.com/tests/functional/lib/setup.js:55:9)
    at emitOne (events.js:116:13)
    at ClientRequest.emit (events.js:211:7)
    at Socket.socketErrorListener (_http_client.js:387:9)
    at emitOne (events.js:116:13)
    at Socket.emit (events.js:211:7)
    at emitErrorNT (internal/streams/destroy.js:64:8)
    at _combinedTickCallback (internal/process/next_tick.js:138:11)
    at process._tickCallback (internal/process/next_tick.js:180:9) reported: true }
npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR! webcompat@ test:js: `node ./tests/functional/_intern.js "--reporters=runner" "--firefoxBinary=/home/travis/firefox-58.0/firefox/firefox"`
npm ERR! Exit status 1
npm ERR! 
npm ERR! Failed at the webcompat@ test:js script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.

npm ERR! A complete log of this run can be found in:
npm ERR!     /home/travis/.npm/_logs/2018-06-06T10_17_47_937Z-debug.log

travis_time:end:18c92ed2:start=1528280266989096368,finish=1528280267945871463,duration=956775095

[zoepage]

Thanks @patrickhlauke for your work <3

Just to give some context, the SVG title were added due to a SVG bug in Firefox nightly 59 (AFAIR).
On hover the SVG disappeared. I might be worth checking, just to be sure if this still happens.

[patrickhlauke]

@zoepage worst case, <title> can be kept, as it would be neutralised by the aria-hidden="true" on the <svg> itself.

not sure about the failure @TravisBuddy is reporting there. is the test that fails looking for specific html that was optimized away? (i'm a bit of a dope when it comes to all this hip technology like CI etc...)

[patrickhlauke]

worked out what the deal was with the failing unit test, i think...

[karlcow]

Ah cool! This replicates part of the pull request in #2473.
Let's get rid of mine and take @patrickhlauke 's one.
@patrickhlauke long time no see. ❤️

[patrickhlauke]

👍 ❤️

[miketaylr]

h cool! This replicates part of the pull request in #2473.
Let's get rid of mine and take @patrickhlauke 's one.

Cool, I'll do that.

[miketaylr]

might be worth checking, just to be sure if this still happens.

I don't see this bug.

[miketaylr]

Thanks Patrick!

[miketaylr]

Oops, I linked the wrong issue. :P