Fixes #2474 - Properly send along the submit_type to the server.

[miketaylr]

Thanks for finding this bug @karlcow.

This underscores a critical weakness: we need functional tests for bug creation (ideally that don't create real bugs so we don't get labelled as spammers).

r? @karlcow

Note: tags v11.0.0 and v11.0.1 aren't safe to deploy, but we'll cut v11.0.2 and deploy that once this is merged.

[karlcow]

This underscores a critical weakness: we need functional tests for bug creation (ideally that don't create real bugs so we don't get labelled as spammers).

In fact it's probably a couple of things here.

1. Improve /issues/new for form testability  #2479 Most of the parts in this view should be in helpers functions easily testable. The mistake was a missing key in the form dictionary triggering the third abort.
2. Add unit tests for HTTP POST on test_urls #2480 The HTTP POST on the webcompat side can be tested in unit-tests, as we know what we want to receive and what we want to send back to the browser. The GitHub data just needs to be mocked. To read again stuff in Unit tests for API endpoints #396
3. Adds logging for failures mode such as HTTP 400. #2481 The Abort 400 should maybe come with a log message.
4. In this case I have the feeling that 400 was not the appropriate answer, but 500, because it's a failure of our code. So there's probably something to fix here too.
5. Probably part also of [cleaning] form.py extracts multiple times some values in the same function. #1997 work

[karlcow]

Thanks @miketaylr
Wonderful! This is working again. 🎉 time.

Tested Anonymous bug reporting.
And github login. Both are working. Images are working too.

r+ @miketaylr