Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #2431 - Adds changelog title normalization. #2433

Merged
merged 2 commits into from
Apr 30, 2018

Conversation

karlcow
Copy link
Member

@karlcow karlcow commented Apr 29, 2018

@TravisBuddy
Copy link

TravisBuddy commented Apr 29, 2018

Hey @karlcow,
Something went wrong with the build.

TravisCI finished with status errored, which means the build failed because something unrelated to the tests, like a problem a dependency or the build process itself.

@karlcow
Copy link
Member Author

karlcow commented Apr 30, 2018

Thanks travis. My bad. repushing.

@miketaylr
Copy link
Member

a pep8 error:

$ pep8 --ignore=E402 webcompat/ tests/ config/secrets.py.example
tests/unit/test_tools_changelog.py:31:13: E123 closing bracket does not match indentation of opening bracket's line
tests/unit/test_tools_changelog.py:32:13: E123 closing bracket does not match indentation of opening bracket's line

@@ -0,0 +1,61 @@
#!/usr/bin/env python

This comment was marked as abuse.

Copy link
Member

@miketaylr miketaylr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Karl!

@miketaylr
Copy link
Member

(feel free to merge once the pep8 error is fixed)

@karlcow
Copy link
Member Author

karlcow commented Apr 30, 2018

hmmm I need to fix my sublimetext linter. I'm having too many of these lately. Thanks for catching this one.

@karlcow
Copy link
Member Author

karlcow commented Apr 30, 2018

ok fixed the mistake.

🐝 06:04:22 ~/code/webcompat.com
→ pep8 --ignore=E402 tests/
🐝 06:04:50 ~/code/webcompat.com
→ nosetests tests/unit/test_tools_changelog.py
..
----------------------------------------------------------------------
Ran 2 tests in 0.001s

OK

Let's run travis and I will merge. Thanks @miketaylr

@karlcow karlcow merged commit c987456 into webcompat:master Apr 30, 2018
@karlcow karlcow deleted the 2431/1 branch April 30, 2018 21:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants