Fixes #2042: Send details params content via a hidden input. #2395

miketaylr · 2018-04-16T18:56:43Z

The user won't see the pref values until the report has been created. This should be less confusing.

miketaylr · 2018-04-16T18:56:53Z

webcompat/form.py

+def get_details(details_string):
+    """Return details content as a formatted string, if it was JSON. Otherwise,
+    just return the string as-is."""
+    # TODO: file a bug and change DecoderDoctor to encode as JSON so we only


karlcow

My only request for change is about details_map

See fit for the rest.

Thanks @miketaylr

tests/unit/test_helpers.py

+                 {'': ''}, {'cool': 'cool'}, {u'\U0001f480': u'💀'}]
+        for test in tests:
+            for output, _input in test.iteritems():
+                self.assertEqual(get_str_value(_input), output)


tests/unit/test_helpers.py

+                 {'': ''}, {'cool': 'cool'}, {u'\U0001f480': u'💀'}]
+        for test in tests:
+            for output, _input in test.iteritems():
+                self.assertEqual(get_str_value(_input), output)


webcompat/form.py

+    try:
+        details = json.loads(content)
+        for key, value in details.iteritems():
+            rv += key + ': ' + get_str_value(value) + '\n'


webcompat/helpers.py

@@ -74,6 +74,15 @@ def md5_checksum(file_path):
        return m.hexdigest()


+def get_str_value(val):
+    detailsMap = {False: 'false', True: 'true', None: 'null'}


webcompat/form.py

+    details = form_object.get('details')
+    if details:
+        body += u'\n\n**Details**\n{details}'.format(
+            details=get_details(details))


TravisBuddy · 2018-04-18T00:45:51Z

Travis tests have failed

Hey @miketaylr,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

miketaylr · 2018-04-18T00:46:32Z

@karlcow can you have another look please? The last commit is untested, this airplane wifi is like 28kbps, I don't have the patience to file a test issue (will do tonight or tomorrow).

karlcow · 2018-04-18T01:15:48Z

With your latest modifications.

🐝 10:00:06 ~/code/webcompat.com
→ nosetests
...................................................................................
----------------------------------------------------------------------
Ran 83 tests in 2.624s

OK

This one is difficult to test locally, given this is happening only when we use report site issue…

karlcow · 2018-04-18T01:16:40Z

but nosetests are working locally :)

miketaylr · 2018-04-18T16:37:03Z

thanks!

miketaylr · 2018-04-18T16:40:59Z

Testing on staging... unsure what's up:

Will investigate!

miketaylr · 2018-04-18T16:41:12Z

(this was after clicking "report anonymously")

miketaylr · 2018-04-18T16:47:51Z

2018/04/18 16:40:22 [error] 16916#0: *96559 upstream prematurely closed connection while reading response header from upstream, client: xxx, server: staging.webcompat.com, request: "POST /issues/new HTTP/1.1", upstream: "xxx/uwsgi-staging.sock:", host: "staging.webcompat.com", referrer: "https://staging.webcompat.com/issues/new?url=https%3A%2F%2Fgithub.com%2Fwebcompat%2Fwebcompat.com%2Fpull%2F2395%23issuecomment-382205773&src=desktop-reporter&details=%7B%22gfx.webrender.all%22%3Afalse%2C%22gfx.webrender.blob-images%22%3A1%2C%22gfx.webrender.enabled%22%3Afalse%2C%22image.mem.shared%22%3A2%7D"

miketaylr · 2018-04-18T16:50:47Z

Ah, unrelated to nginx. Just a python error:

Traceback (most recent call last):
  File "/usr/local/lib/python2.7/dist-packages/flask/app.py", line 1994, in __call__
    return self.wsgi_app(environ, start_response)
  File "/usr/local/lib/python2.7/dist-packages/flask/app.py", line 1985, in wsgi_app
    response = self.handle_exception(e)
  File "/usr/local/lib/python2.7/dist-packages/flask/app.py", line 1540, in handle_exception
    reraise(exc_type, exc_value, tb)
  File "/usr/local/lib/python2.7/dist-packages/flask/app.py", line 1982, in wsgi_app
    response = self.full_dispatch_request()
  File "/usr/local/lib/python2.7/dist-packages/flask/app.py", line 1614, in full_dispatch_request
    rv = self.handle_user_exception(e)
  File "/usr/local/lib/python2.7/dist-packages/flask/app.py", line 1517, in handle_user_exception
    reraise(exc_type, exc_value, tb)
  File "/usr/local/lib/python2.7/dist-packages/flask/app.py", line 1612, in full_dispatch_request
    rv = self.dispatch_request()
  File "/usr/local/lib/python2.7/dist-packages/flask/app.py", line 1598, in dispatch_request
    return self.view_functions[rule.endpoint](**req.view_args)
  File "./webcompat/views.py", line 229, in create_issue
    response = report_issue(form, proxy=True).json()
  File "./webcompat/issues.py", line 24, in report_issue
    data=json.dumps(build_formdata(form)))
  File "./webcompat/form.py", line 307, in build_formdata
    body += build_details(details)
  File "./webcompat/form.py", line 124, in build_details
    </details>""".format(get_details(details))
KeyError: 'details'

Will file a bug and send in a patch. Yay for untested airplane code. ✈️

miketaylr requested a review from karlcow April 16, 2018 18:56

miketaylr added the in progress label Apr 16, 2018

miketaylr mentioned this pull request Apr 16, 2018

2018-Q2 1.5 Add contextual metadata to new in-product webcompat.com bug reports mozilla/webcompat-team-okrs#5

Closed

7 tasks

miketaylr commented Apr 16, 2018

View reviewed changes

miketaylr force-pushed the issues/2042/1 branch from c052f22 to e031394 Compare April 16, 2018 21:28

karlcow requested changes Apr 17, 2018

View reviewed changes

miketaylr added 7 commits April 17, 2018 19:14

Issue #2042. Update comment with permalink.

2be4e46

Issue #2042. Comment fixes.

0ef26b3

Issue #2042. Add a helper to convert Python to expected values.

b99a85c

Issue #2042. Get and format details param from form object.

5808230

Issue #2042. Send details param content as hidden details input.

388909b

Issue #2042. Update details param tests.

5cf1163

Issue #2042. Display details (Browser Configuration) in <details>.

5c2a907

miketaylr force-pushed the issues/2042/1 branch from e031394 to 5c2a907 Compare April 18, 2018 00:43

karlcow merged commit fa99d5d into master Apr 18, 2018

karlcow added status: add to changelog and removed in progress labels Apr 18, 2018

miketaylr deleted the issues/2042/1 branch April 18, 2018 16:37

miketaylr removed the status: add to changelog label Apr 26, 2018

karlcow mentioned this pull request Apr 20, 2020

Fixes #3289 - Add support for nested ul in browser details #3290

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fixes #2042: Send details params content via a hidden input. #2395

Fixes #2042: Send details params content via a hidden input. #2395

miketaylr commented Apr 16, 2018

miketaylr commented Apr 16, 2018

This comment was marked as abuse.

This comment was marked as abuse.

karlcow left a comment

This comment was marked as abuse.

This comment was marked as abuse.

This comment was marked as abuse.

This comment was marked as abuse.

This comment was marked as abuse.

This comment was marked as abuse.

This comment was marked as abuse.

This comment was marked as abuse.

This comment was marked as abuse.

TravisBuddy commented Apr 18, 2018 •

edited

Loading

miketaylr commented Apr 18, 2018

karlcow commented Apr 18, 2018

karlcow commented Apr 18, 2018

miketaylr commented Apr 18, 2018

miketaylr commented Apr 18, 2018

miketaylr commented Apr 18, 2018

miketaylr commented Apr 18, 2018

miketaylr commented Apr 18, 2018

Fixes #2042: Send details params content via a hidden input. #2395

Fixes #2042: Send details params content via a hidden input. #2395

Conversation

miketaylr commented Apr 16, 2018

miketaylr commented Apr 16, 2018

This comment was marked as abuse.

This comment was marked as abuse.

karlcow left a comment

Choose a reason for hiding this comment

This comment was marked as abuse.

This comment was marked as abuse.

This comment was marked as abuse.

This comment was marked as abuse.

This comment was marked as abuse.

This comment was marked as abuse.

This comment was marked as abuse.

This comment was marked as abuse.

This comment was marked as abuse.

TravisBuddy commented Apr 18, 2018 • edited Loading

Travis tests have failed

miketaylr commented Apr 18, 2018

karlcow commented Apr 18, 2018

karlcow commented Apr 18, 2018

miketaylr commented Apr 18, 2018

miketaylr commented Apr 18, 2018

miketaylr commented Apr 18, 2018

miketaylr commented Apr 18, 2018

miketaylr commented Apr 18, 2018

TravisBuddy commented Apr 18, 2018 •

edited

Loading