Skip to content

Issue #2334. Ensure that we consider browser-sent images as valid. #2335

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 28, 2018

Conversation

miketaylr
Copy link
Member

r? @zoepage

npm run test:js -- --grep="remove image upload button"

screen shot 2018-03-28 at 3 45 15 pm

@miketaylr
Copy link
Member Author

The bug is that without the .is-validated class, it never gets a higher z-index which is controlled by this selector, so you can't actually click it:

.is-validated .label-remove {
    visibility: visible;
    z-index: 40;
    cursor: pointer;
    border: 0 none;
    outline: 0;
}

@zoepage zoepage merged commit 2711abe into refactor Mar 28, 2018
@zoepage zoepage deleted the issues/2334/1 branch March 28, 2018 20:58
@zoepage
Copy link
Member

zoepage commented Mar 28, 2018

LGTM! :)))

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants