Fixes #2019. Append extra labels in correct format. #2020
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The intermediary metadata list expects a list of tuples, with the metadata key being the first member of the tuple, and its value the second.
|
r? @karlcow |
miketaylr
commented
Jan 12, 2018
| @@ -129,6 +131,17 @@ def test_get_metadata(self): | |||
| actual = form.get_metadata(metadata_keys, form_object) | |||
| expected = u'<!-- @sky: blue -->\n<!-- @earth: None -->\n' | |||
| self.assertEqual(actual, expected) | |||
| form_object = MultiDict([ | |||
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
karlcow
approved these changes
Jan 12, 2018
There was a problem hiding this comment.
→ nosetests -v tests/test_form.py
The data body sent to GitHub API. ... ok
Check that domain name is extracted. ... ok
Checks we return the right form with the appropriate data. ... ok
HTML comments need the right values depending on the keys. ... ok
Check that metadata is processed and wrapped. ... ok
Avoid some type of strings. ... ok
Check that URL is normalized. ... ok
Check that appropriate radio button label is returned. ... ok
----------------------------------------------------------------------
Ran 8 tests in 0.006s
OK
Thanks Mike. This is all good.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The intermediary metadata list expects a list of tuples, with the
metadata key being the first member of the tuple, and its value the
second.
Also, adds an assertion to explicitly test getting
extra_labelsmetadata, since it gets special handling.