Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #1586 - Adds a data/ path logic to the code. #1725

Merged
merged 4 commits into from
Aug 29, 2017
Merged

Fixes #1586 - Adds a data/ path logic to the code. #1725

merged 4 commits into from
Aug 29, 2017

Conversation

karlcow
Copy link
Member

@karlcow karlcow commented Aug 24, 2017

The data/ is meant to be ignored per #1586.

I modified the code to make sure that the db could live in the new directory.

@miketaylr r?

karlcow added 2 commits August 24, 2017 15:18
@karlcow
Issue webcompat#1586 - Cleans the syntax according to webcompat#1473
9706502
@karlcow
Issue webcompat#1586 - Adds a data/ path
0534f03 
- Adds a data path
- Makes sure it exists
- Adjusts the code to this data path.
@karlcow karlcow requested a review from miketaylr August 24, 2017 06:25
@karlcow
Copy link
Member Author

karlcow commented Aug 24, 2017 

→ nosetests
...............................................................
----------------------------------------------------------------------
Ran 63 tests in 0.945s

OK

miketaylr
miketaylr requested changes Aug 24, 2017
View reviewed changes
Copy link
Member

@miketaylr miketaylr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Minor comment nit, but ready to pull in after tweaking that -- thanks!

.gitignore Outdated
# backup folder contains the issues.db backup file with issues dump
# for the previous versions
backups/*.db
# data folder contains everything we are not interested

This comment was marked as abuse.

Sign in to view

This comment was marked as abuse.

Sign in to view

This comment was marked as abuse.

Sign in to view

karlcow added 2 commits August 25, 2017 15:41
@karlcow
Issue webcompat#1586 - Adds a data/ path
074204d 
- Adds a data path
- Makes sure it exists
- Adjusts the code to this data path.
@karlcow
Merging my rebase
24dcc1d
@miketaylr miketaylr merged commit 93d9472 into webcompat:master Aug 29, 2017
@miketaylr
Copy link
Member

Thanks!

@karlcow karlcow deleted the 1586/1 branch March 30, 2018 05:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@miketaylr miketaylr miketaylr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@karlcow @miketaylr