Fixes #1574 - update regex and target field for text url removal #1632
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@karlcow R? it is JS but I think it was your code. also there was an existing test which appeared relevant. |
karlcow
requested changes
Jul 6, 2017
There was a problem hiding this comment.
after this fix. This can be merge. If modifications are done after Friday. I'll defer to @zoepage or @miketaylr for the merge.
webcompat/static/js/lib/bugform.js
Outdated
| "" | ||
| ); | ||
| this.stepsToReproduceField.val(function(idx, value) { | ||
| return value.replace(/\[!\[[^\]]+\]\([^\)]+\)\]\([^\)]+\)$/); |
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
|
Looks good, thanks @cch5ng! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
update existing test
cleanup: #1574; remove comments
tests: #1574; update existing selector