Fixes #1455 - prevent shortkeys to fire in comment textarea #1464
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @miketaylr |
zoepage
changed the title
|
(I think this needs to be rebased against latest master...) So, it turns out this regression was introduced by #1431... and it was my suggestion to use mousetrap to handle ctrl+enter... which meant the two existing shortcuts would work. Oops. 🙈 This looks good, but we should rename the |
miketaylr
approved these changes
Mar 30, 2017
| @@ -24,9 +24,9 @@ issues.LabelsView = Backbone.View.extend({ | |||
| "click .js-LabelEditorLauncher.is-active": "closeEditor" | |||
| }, | |||
| keyboardEvents: { | |||
| "l": "labelWrap" | |||
| "l": "labelWarp" | |||
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
|
I'll file a followup issue for the renaming, that's a very good "good first bug". :) |
|
@miketaylr you merged, so no rebase? :) |
Yeah, sorry -- the merge applied cleanly. All good! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.