Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #1318 - Add the correct path for requirements.txt #1321

Merged
merged 1 commit into from
Feb 2, 2017
Merged

Fixes #1318 - Add the correct path for requirements.txt #1321

merged 1 commit into from
Feb 2, 2017

Conversation

zoepage
Copy link
Member

@zoepage zoepage commented Feb 2, 2017

@karlcow ? :)

@zoepage zoepage mentioned this pull request Feb 2, 2017
Closed
@miketaylr miketaylr requested a review from karlcow February 2, 2017 21:22
@karlcow karlcow changed the title Issue #1318 - Fix path for requirements.txt Fixes #1318 - Add the correct path for requirements.txt Feb 2, 2017
@karlcow
Copy link
Member

karlcow commented Feb 2, 2017

I'm fixing the syntax of the pull request.

The title of the PR has a specific format too. see step 9

Step 9 gives the example. (I guess we really need to fix #1134 )
Fixes #123 - Fixes broken layout on mobile browsers

karlcow
karlcow approved these changes Feb 2, 2017
View reviewed changes
Copy link
Member

@karlcow karlcow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @zoepage 👌

@karlcow karlcow merged commit e3807b2 into master Feb 2, 2017
@karlcow
Copy link
Member

karlcow commented Feb 2, 2017

@zoepage

nit: in the future, for asking the review r? @karlcow or use the button on the top right of the pull request. Why? Because some people have specific filters to catch some emails in priority ;)

@miketaylr miketaylr deleted the issues/1318/1 branch February 2, 2017 23:19
@zoepage
Copy link
Member Author

zoepage commented Feb 2, 2017

@karlcow you folks are way too smart :)))

@miketaylr
Copy link
Member

(I have one of these inbox filters ^_^)
screen shot 2017-02-02 at 3 19 57 pm

@karlcow
Copy link
Member

karlcow commented Feb 3, 2017

🤡
capture d ecran 2017-02-03 a 10 07 22

@karlcow
Copy link
Member

karlcow commented Feb 3, 2017

capture d ecran 2017-02-03 a 10 08 30

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@karlcow karlcow karlcow approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zoepage @karlcow @miketaylr