Fixes #1263 - Fixes aria attributes typo in templates #1302
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karlcow
requested changes
Jan 25, 2017
There was a problem hiding this comment.
- could you change the commit message so it respects the syntax of the guidelines.
https://github.com/webcompat/webcompat.com/blob/master/CONTRIBUTING.md#submission-guidelines
for example "Issue #1263 - fixes aria typo in template"
- Check also how we do titles for Pull Request.
+1 for the changes once this is modified.
karlcow
changed the title
|
I modified the title of the PR according to our guidelines. :) |
|
And thanks for the Pull Request. |
Fix 2 typo from ara-hidden -> aria-hidden
|
thanks @MDTsai 👍 |
|
Perfect! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix 2 typo from ara-hidden -> aria-hidden. @karlcow , could you please help to check this?