Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #1261 - Improve the comment form and upload image area #1265

Merged
merged 4 commits into from
Jan 17, 2017

Conversation

karlcow
Copy link
Member

@karlcow karlcow commented Jan 5, 2017

This pull request implements the proposal of #1261 following the recommendation of @magsout for the syntax

@karlcow
Copy link
Member Author

karlcow commented Jan 5, 2017

r? @masgout

@magsout
Copy link
Member

magsout commented Jan 12, 2017

ahhhh, 20 minutes to understand you PR is coming from another repo... So when I tested you PR, I don"t see antything on my local..

Copy link
Member

@magsout magsout left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job @karlcow lgtm r+

@@ -26,6 +26,7 @@
background-image: none;
user-select: none;
-webkit-appearance: none;
margin: 0 1em .5em 1em;

This comment was marked as abuse.

This comment was marked as abuse.

This comment was marked as abuse.

This comment was marked as abuse.

@magsout
Copy link
Member

magsout commented Jan 17, 2017

r+ @karlcow

@magsout magsout merged commit 171548d into webcompat:master Jan 17, 2017
@magsout
Copy link
Member

magsout commented Jan 17, 2017

Very good job @karlcow

@karlcow
Copy link
Member Author

karlcow commented Jan 18, 2017

Thanks @magsout ❤️

karlcow added a commit to karlcow/webcompat.com that referenced this pull request Jan 19, 2017
miketaylr pushed a commit that referenced this pull request Feb 2, 2017
Fixes #1292 - Regression introduced by #1265
@karlcow karlcow deleted the 1261/1 branch February 9, 2017 07:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants