Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #1167. Show green checkmark for os and browser fields. #1186

Merged
merged 9 commits into from
Oct 13, 2016
Merged

Fixes #1167. Show green checkmark for os and browser fields. #1186

merged 9 commits into from
Oct 13, 2016

Conversation

miketaylr
Copy link
Member

If they're empty, we just remove it, rather than show a red X.

@miketaylr
Copy link
Member Author

(not ready for review, debugging busted tests)

@miketaylr
Copy link
Member Author

⚡️ 🚨

FAIL: main - Reporting (non-auth) - (optional) browser + os validation (701ms)

AssertionError: expected 'wc-Form-group js-Form-group is-validated js-no-error' to not include 'js-no-error'

  at Function.assert.notInclude  <node_modules/intern/node_modules/chai/chai.js:2997:52>

  at CompatCommand.<anonymous>  <tests/functional/reporting-non-auth.js:117:18>

  at runCallback  <node_modules/intern/node_modules/leadfoot/Command.js:509:31>

  at CompatCommand.<anonymous>  <node_modules/intern/node_modules/leadfoot/Command.js:526:11>
...

To be continued.

@miketaylr
Copy link
Member Author

Sweet, got last failing test to pass. Turns out it was failing because I had a bug. Imagine that!

r? @adamopenweb

@miketaylr
Copy link
Member Author

@adamopenweb ping!

@miketaylr miketaylr mentioned this pull request Oct 13, 2016
Closed
@adamopenweb
Copy link
Collaborator

LGTM.
r+

@adamopenweb adamopenweb merged commit 37dba31 into master Oct 13, 2016
@adamopenweb adamopenweb deleted the issues/1167 branch October 13, 2016 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@miketaylr @adamopenweb