Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1084/1 spring cleaning of syntax and imports #1085

Merged
merged 2 commits into from
Jun 6, 2016

Conversation

karlcow
Copy link
Member

@karlcow karlcow commented Jun 6, 2016

Nothing dramatic, juts minor and cosmetic changes.
But a trajectory correction to avoid more discrepancies.

@karlcow
Copy link
Member Author

karlcow commented Jun 6, 2016

r? @miketaylr

@miketaylr
Copy link
Member

Nice. Love contributions like this. ❤️

@miketaylr
Copy link
Member

Hm, Travis is not very happy:

$ nosetests

F.F..............................E....

I just retriggered the build, but can you locally verify that tests are passing in your branch @karlcow?
I just pulled down your code and I don't have failures here.

@karlcow
Copy link
Member Author

karlcow commented Jun 6, 2016

Sure.

→ git status
On branch 1084/1
nothing to commit, working directory clean
(webcompatcom)18:03:08 ~/code/webcompat.com
→ nosetests
......................................
----------------------------------------------------------------------
Ran 38 tests in 7.458s

OK

@miketaylr
Copy link
Member

Cool, thanks @karlcow. I think this is a rate limit issue from Travis IPs. Something for us to solve in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants