Fixes #994. Better handle 413 errors when uploading an image. #1016
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Redirecting review to Adam, I think @magsout is swamped at work right now -- no issues ❤️ ) r? @adamopenweb |
|
OK, now that #1018 is in will fix the merge conflicts. |
added 3 commits
April 27, 2016 14:50
Also test that img_too_big isn't true before re-enabling submits.
Also, make sure z-index is higher than the image preview.
|
Alright, rebased and fixed conflicts (and just manually tested again). when travis is green, can you take a look @adamopenweb? |
| @@ -284,7 +299,7 @@ function BugForm() { | |||
| }; | |||
|
|
|||
| this.addPreviewBackground = function(dataURI) { | |||
| if (!_.startsWith(dataURI, 'data:image/png;base64')) { | |||
| if (!_.startsWith(dataURI, 'data:image/')) { | |||
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
|
lgtm 👍 r+ ? sorry for the daly .. |
|
But you ask @adamopenweb so maybe let him do the review ? |
|
No worries about the delay @magsout! |
|
I'm gonna go ahead and merge, I think @adamopenweb was waiting on me to fix merge conflict junk before reviewing -- then I can do a deploy. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR has 3 related changes:
r? @magsout