Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Un-authorized user comments appear as comments from webcompat-bot #845

Closed
hallvors opened this issue Dec 9, 2015 · 6 comments
Closed

Un-authorized user comments appear as comments from webcompat-bot #845

hallvors opened this issue Dec 9, 2015 · 6 comments

Comments

@hallvors
Copy link
Contributor

hallvors commented Dec 9, 2015

Client-side we don't show a TEXTAREA for inputting comments if the user is not logged in via GitHub. However, under the hood non-authed users can still submit comments. They will appear as being posted by webcompat-bot. Usually, this will likely happen by accident - maybe if the user loaded an issue, logged out from GitHub in a different tab, then tried to comment .. or something like that??

Comment POSTing presumably starts the journey through the backend here:
https://github.com/webcompat/webcompat.com/blob/master/webcompat/api/endpoints.py#L214
that method just forwards all bits to api_request
https://github.com/webcompat/webcompat.com/blob/master/webcompat/helpers.py#L401
which, if the user is not logged in, calls proxy_request
https://github.com/webcompat/webcompat.com/blob/master/webcompat/helpers.py#L379
Voila, anonymous posting - right?

@miketaylr
Copy link
Member

Yeah, this is bogus. Thanks for filing @hallvors.

@cch5ng
Copy link
Contributor

cch5ng commented Jun 24, 2016

hi, ok to work on this? I still have 980 on my todo's but would like to work on something while waiting on a blocking bug (it is probably low priority). thanks.

@miketaylr
Copy link
Member

@cch5ng yes!

@miketaylr miketaylr assigned miketaylr and cch5ng and unassigned miketaylr Jun 24, 2016
@miketaylr
Copy link
Member

hi, ok to work on this?

@cch5ng are you still planning on working on this?

@cch5ng
Copy link
Contributor

cch5ng commented Feb 28, 2017

@miketaylr I can release this one but continue to work on issue 980. I will unassign myself. thx

@cch5ng cch5ng removed their assignment Feb 28, 2017
@miketaylr
Copy link
Member

Cool -- thanks! If you come back when #980 is done and nobody else if working on this, feel free to snag it again.

karlcow added a commit to karlcow/webcompat.com that referenced this issue May 12, 2017
karlcow added a commit to karlcow/webcompat.com that referenced this issue May 12, 2017
@karlcow karlcow self-assigned this May 12, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants