Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clicking label to filter list does not work on the front page #787

Closed
hallvors opened this issue Oct 22, 2015 · 1 comment
Closed

Clicking label to filter list does not work on the front page #787

hallvors opened this issue Oct 22, 2015 · 1 comment
Assignees

Comments

@hallvors
Copy link
Contributor

Like #693 on the issues list, clicking a label to see only issues with that label does not do anything on the webcompat.com front page.

The underlying reason is that this functionality is in issues-list.js, and the front page does not include issues-list.js yet uses the same (or similar) markup and UI.

Options:

  • Make the labels unclickable (IMHO it's not a great loss of functionality)
  • Make the label links go to the /issues/ page with a suitable query string and don't use JS click handlers
  • Include issues-list.js on front page

Opinions?
@miketaylr , @karlcow , @magsout , @calexity ?

@miketaylr
Copy link
Member

Oops, that's an oversight.

I think the first two options are fine, originally we didn't show labels on the homepage but I think they snuck in when we were doing some consolidation of templates/styles. (Because I'm lazy I would probably just remove the hyperlinks).

@hallvors hallvors self-assigned this Oct 29, 2015
miketaylr pushed a commit that referenced this issue Oct 29, 2015
Labels on front page should work, fixes #787
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants