Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "Pressing g takes you to this page on Github" #449

Closed
calexity opened this issue Dec 5, 2014 · 10 comments
Closed

Add "Pressing g takes you to this page on Github" #449

calexity opened this issue Dec 5, 2014 · 10 comments

Comments

@calexity
Copy link
Contributor

calexity commented Dec 5, 2014

As a webcompat.com user
When I look at All issues or an individual issue
Then I want to be able to see the Github view easier
Until webcompat.com is more awesome.

@miketaylr
Copy link
Member

If someone wants to submit a patch for the JS parts of this, it's just adding something similar to this to the MainView in js/lib/issue-list.js (and the corresponding githubWarp method).

@tagawa
Copy link
Member

tagawa commented Dec 7, 2014

Pull request sent for the JS part: #460

@calexity
Copy link
Contributor Author

calexity commented Dec 8, 2014

Here's a UI idea - bottom Right corner is for shortcuts (on mobile, would be right above the footer yellow line)

Gray box is #414402 with a 3px radius, Letter G is white

All Issues
shortcutonallissues

Issue Detail
shortcutonissue

@tagawa
Copy link
Member

tagawa commented Dec 8, 2014

Looks good to me - nice and consistent with the rest of the UI.

@miketaylr
Copy link
Member

Ooh, very nice @calexity.

miketaylr pushed a commit that referenced this issue Dec 9, 2014
Issue #449 - Tests for g to GitHub issues functionality
@miketaylr
Copy link
Member

So here's a design question: how do we do this for the issues page without looking so gross? :p

Also, In my patch I've used lowercase 'g' because that's how it works. Uppercase G looks less wonky though--so maybe we just support both?

screenshot

@calexity
Copy link
Contributor Author

@miketaylr my bad for not logging in. What about moving those CTAs over to the left? Or more centered under the comment box? If you go left, we should align to left of comment box. What do you think?

Alternatively, we can move the shortcut to bottom center on its own line with more space.

@miketaylr
Copy link
Member

I dunno, I think it looks really nice on the /issues page as is. We discussed redesigning this page anyways, maybe a solution gets more obvious as that point. /me punts 🏈

magsout added a commit that referenced this issue Dec 19, 2014
Issue #449 - Add a visual hint for the 'g' => GitHub shortcut.
@miketaylr
Copy link
Member

Fixed now.

@calexity
Copy link
Contributor Author

calexity commented Mar 3, 2015

Thank you!

On Mon, Mar 2, 2015 at 9:13 AM Mike Taylor [email protected] wrote:

Closed #449 #449.


Reply to this email directly or view it on GitHub
#449 (comment).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants