Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Follow Link header URIs for pagination #420

Closed
miketaylr opened this issue Nov 21, 2014 · 1 comment
Closed

Follow Link header URIs for pagination #420

miketaylr opened this issue Nov 21, 2014 · 1 comment
Assignees
@miketaylr
Labels
status: needs tests type: site-development
Milestone
Ship full issues ...

Comments

@miketaylr
Copy link
Member

Follow up from #370. Pagination traversal is much simpler if we just go where GitHub is telling us where to go.
@miketaylr miketaylr self-assigned this Nov 21, 2014
@miketaylr miketaylr added this to the Ship full issues page milestone Nov 21, 2014
miketaylr pushed a commit that referenced this issue Nov 21, 2014
Issue #420 - Add getNextPage and getPrevPage methods to model.
eb01768
@karlcow
Copy link
Member

karlcow commented Nov 24, 2014

Hypermedia driven API ;) And agreed.
This is exactly the goal.

@miketaylr miketaylr mentioned this issue Nov 24, 2014
Merged
miketaylr pushed a commit that referenced this issue Nov 24, 2014
Issue #420 - Add /issues/paginate endpoint to traverse Link URIs.
c7e4354
miketaylr pushed a commit that referenced this issue Nov 24, 2014
Issue #420 - encode URLs before we send them to the server.
d97b24f
miketaylr pushed a commit that referenced this issue Nov 24, 2014
Issue #420 - Support merging params with encoded link URLs.
fb967c8
miketaylr pushed a commit that referenced this issue Nov 24, 2014
Issue #420 - Pass next or prev URI link to server for pagination.
916e67f
miketaylr pushed a commit that referenced this issue Nov 24, 2014
Issue #420 - Return null if we didn't get a Link header
bfca36f 
(when checking to enable or disable pagination links)
miketaylr pushed a commit that referenced this issue Nov 24, 2014
Issue #420 - Add getNextPage and getPrevPage methods to model.
7bf2bb8
miketaylr pushed a commit that referenced this issue Nov 24, 2014
Issue #420 - Add /issues/paginate endpoint to traverse Link URIs.
114cf74
miketaylr pushed a commit that referenced this issue Nov 24, 2014
Issue #420 - encode URLs before we send them to the server.
b641b42
miketaylr pushed a commit that referenced this issue Nov 24, 2014
Issue #420 - Support merging params with encoded link URLs.
980ac8f
miketaylr pushed a commit that referenced this issue Nov 24, 2014
Issue #420 - Pass next or prev URI link to server for pagination.
9ae1996
miketaylr pushed a commit that referenced this issue Nov 24, 2014
Issue #420 - Return null if we didn't get a Link header
6d90120 
(when checking to enable or disable pagination links)
miketaylr pushed a commit that referenced this issue Nov 24, 2014
Issue #420 - Return null if we didn't get a Link header
f7e2244 
(when checking to enable or disable pagination links)
miketaylr pushed a commit that referenced this issue Nov 24, 2014
Issue #420 - Return null if we didn't get a Link header
2f70020 
(when checking to enable or disable pagination links)
miketaylr pushed a commit that referenced this issue Nov 24, 2014
Issue #420 - Remove obsolete pagination methods from IssueCollection
e1282d1
miketaylr pushed a commit that referenced this issue Nov 24, 2014
Issue #420 - Add tests for link param validation.
33eb430
@miketaylr miketaylr mentioned this issue Nov 24, 2014
Closed
miketaylr pushed a commit that referenced this issue Nov 25, 2014
Issue #420 - set per_page defaults in updateIssues
8040309
miketaylr pushed a commit that referenced this issue Nov 25, 2014
Issue #420 - Handle Search API and Issues API results differences in …
6b8e709 
…model

Search comes back as an object, with issues in the items key.
Issues is just an array.
miketaylr pushed a commit that referenced this issue Nov 25, 2014
Issue #420 - Modify /issues/search/untriaged to accept categories
e14b150 
This is a temporary workaround of GitHub's lack of sending
Link headers to the Issues API filtered by label. They have been
contacted and confirmed they are tracking it via an internal issue.
miketaylr pushed a commit that referenced this issue Nov 25, 2014
Issue #420 - Fetch named label filters from /issues/search/ endpoint
5d6a75d 
"closed" remains at /issues/category because requesting issues by
issue state correctly returns Link headers.
miketaylr pushed a commit that referenced this issue Dec 2, 2014
Issue #420 - Remove paginate endpoint and tests
92d995b
miketaylr pushed a commit that referenced this issue Dec 2, 2014
Issue #420 - Strip out whitespace from rel_info
418743f
miketaylr pushed a commit that referenced this issue Dec 2, 2014
Issue #420 - Add compound rewrite_and_sanitize_link method.
a4c7be7
miketaylr pushed a commit that referenced this issue Dec 2, 2014
Issue #420 - get model url directly from getNextPage & getPrevPage me…
27ccc2d 
…thods.
miketaylr pushed a commit that referenced this issue Dec 2, 2014
Issue #420 - Add unit tests for helper methods
0878f10
miketaylr pushed a commit that referenced this issue Dec 3, 2014
Issue #420 - remove unneeded URI encoding from issue model
dbb680e
miketaylr pushed a commit that referenced this issue Dec 5, 2014
Issue #420 - Add getNextPage and getPrevPage methods to model.
b42dfc4
miketaylr pushed a commit that referenced this issue Dec 5, 2014
Issue #420 - encode URLs before we send them to the server.
9fc5ae0
miketaylr pushed a commit that referenced this issue Dec 5, 2014
Issue #420 - Support merging params with encoded link URLs.
4e68df9
miketaylr pushed a commit that referenced this issue Dec 5, 2014
Issue #420 - set per_page defaults in updateIssues
216e6f7
miketaylr pushed a commit that referenced this issue Dec 5, 2014
Issue #420 - Return null if we didn't get a Link header
3f45a7b 
(when checking to enable or disable pagination links)
miketaylr pushed a commit that referenced this issue Dec 5, 2014
Issue #420 - Remove obsolete pagination methods from IssueCollection
8dcd41e
miketaylr pushed a commit that referenced this issue Dec 5, 2014
Issue #420 - Handle Search API and Issues API results differences in …
6c46906 
…model

Search comes back as an object, with issues in the items key.
Issues is just an array.
miketaylr pushed a commit that referenced this issue Dec 5, 2014
Issue #420 - Modify /issues/search/untriaged to accept categories
a130755 
This is a temporary workaround of GitHub's lack of sending
Link headers to the Issues API filtered by label. They have been
contacted and confirmed they are tracking it via an internal issue.
miketaylr pushed a commit that referenced this issue Dec 5, 2014
Issue #420 - Fetch named label filters from /issues/search/ endpoint
8a21cfc 
"closed" remains at /issues/category because requesting issues by
issue state correctly returns Link headers.
miketaylr pushed a commit that referenced this issue Dec 5, 2014
Issue #420 - Rewrite Link headers
bcc4bca
miketaylr pushed a commit that referenced this issue Dec 5, 2014
Issue #420 - Add compound rewrite_and_sanitize_link method.
58f5641
miketaylr pushed a commit that referenced this issue Dec 5, 2014
Issue #420 - Add tests for helper methods.
139dc83
miketaylr pushed a commit that referenced this issue Dec 5, 2014
Issue #420 - Avoid duplicate params
990028b
miketaylr pushed a commit that referenced this issue Dec 5, 2014
Issue #420 - Add tests for helper methods.
d61de2a
miketaylr pushed a commit that referenced this issue Dec 5, 2014
Issue #420 - Avoid duplicate params
43a1cc7
@miketaylr miketaylr mentioned this issue Dec 11, 2014
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@miketaylr miketaylr

Labels
status: needs tests type: site-development
Projects
None yet
Milestone
Ship full issues page
Development

No branches or pull requests
2 participants
@miketaylr @karlcow