Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable issues "pagination" dropdown #372

Closed
miketaylr opened this issue Nov 11, 2014 · 2 comments
Closed

Enable issues "pagination" dropdown #372

miketaylr opened this issue Nov 11, 2014 · 2 comments
Milestone
Ship full issues ...

Comments

@miketaylr
Copy link
Member

See:
issue-list.js#L200-L202
issue-list.js#L211
@miketaylr miketaylr added this to the Ship full issues page milestone Nov 11, 2014
@miketaylr miketaylr mentioned this issue Nov 14, 2014
Merged
@miketaylr
Copy link
Member Author

https://developer.github.com/guides/traversing-with-pagination/#changing-the-number-of-items-received documents the per_page parameter. Up to 100.

miketaylr pushed a commit that referenced this issue Nov 19, 2014
Issue #372 - Add jquery.deparam vendor dependency.
74b69d7
miketaylr pushed a commit that referenced this issue Nov 19, 2014
Issue #372 - Uncomment pagination controls code; add page params.
ec354a9
miketaylr pushed a commit that referenced this issue Nov 19, 2014
Issue #372 - Add method to update model params from dropdown change.
4acb8a3
miketaylr pushed a commit that referenced this issue Nov 20, 2014
Issue #372 - Forward all params from client to GitHub
1de9a06 
We need to use the .copy() method because request.args is
an ImmutableMultiDict. This allows us to modify/update.
miketaylr pushed a commit that referenced this issue Nov 20, 2014
Issue #372 - Rename checkParams to checkURLParams
07155d3
miketaylr pushed a commit that referenced this issue Nov 20, 2014
Issue #372 - DropdownView model now has paramKey and paramValue, rath…
f239717 
…er than combined.
miketaylr pushed a commit that referenced this issue Nov 20, 2014
Issue #372 - Rename checkURLParams to loadIssues to be less confusing.
4b7a4e8
miketaylr pushed a commit that referenced this issue Nov 20, 2014
Issue #372 - Add default per_page and update page regex.
56272ad
miketaylr pushed a commit that referenced this issue Nov 20, 2014
Issue #372: dropdown:change should fire key and value as distinct args.
d8684c7
miketaylr pushed a commit that referenced this issue Nov 20, 2014
Issue #372 - Use $.param to build params in updateIssues method
07f41b8 
squash me with the updateIssues commit
miketaylr pushed a commit that referenced this issue Nov 20, 2014
Issue #372 - updateModelParams should take key, value args.
3340ede
miketaylr pushed a commit that referenced this issue Nov 20, 2014
Issue #372 - pagination should use updateModelparams.
90dd2dc 
This will likely change once Links are followed.
@miketaylr
Copy link
Member Author

OK, this should be mostly everything. I punted on persisting page limit choice in localstorage--I think once we have all the filters/sort options enabled a more general solution will be easier/make more sense.

Will write some tests before sending a PR.

miketaylr pushed a commit that referenced this issue Nov 20, 2014
Issue #372 - Functional tests for pagination dropdown
db6346c
miketaylr pushed a commit that referenced this issue Nov 21, 2014
Issue #372 - store "page_limit" key as view object property
a535516
miketaylr pushed a commit that referenced this issue Nov 21, 2014
Issue #372 - Comment cleanup.
40cc801
miketaylr pushed a commit that referenced this issue Nov 21, 2014
Issue #372 - jshint fixup
09bcddc
miketaylr pushed a commit that referenced this issue Nov 24, 2014
Issue #372 - Add jquery.deparam vendor dependency.
f792ddb
miketaylr pushed a commit that referenced this issue Nov 24, 2014
Issue #372 - Uncomment pagination controls code; add page params.
a9b6910
miketaylr pushed a commit that referenced this issue Nov 24, 2014
Issue #372 - Add method to update model params from dropdown change.
87c5c38
miketaylr pushed a commit that referenced this issue Nov 24, 2014
Issue #372 - Forward all params from client to GitHub
b39eb26 
We need to use the .copy() method because request.args is
an ImmutableMultiDict. This allows us to modify/update.
miketaylr pushed a commit that referenced this issue Nov 24, 2014
Issue #372 - Rename checkParams to checkURLParams
7c1aaef
miketaylr pushed a commit that referenced this issue Nov 24, 2014
Issue #372 - DropdownView model now has paramKey and paramValue, rath…
dbb32fc 
…er than combined.
miketaylr pushed a commit that referenced this issue Nov 24, 2014
Issue #372 - Rename checkURLParams to loadIssues to be less confusing.
d4cbd9c
miketaylr pushed a commit that referenced this issue Nov 24, 2014
Issue #372 - Add default per_page and update page regex.
a81ae1b
miketaylr pushed a commit that referenced this issue Nov 24, 2014
Issue #372: dropdown:change should fire key and value as distinct args.
83899a4
miketaylr pushed a commit that referenced this issue Nov 24, 2014
Issue #372 - Use $.param to build params in updateIssues method
06d6974 
squash me with the updateIssues commit
miketaylr pushed a commit that referenced this issue Nov 24, 2014
Issue #372 - updateModelParams should take key, value args.
6cd675f
miketaylr pushed a commit that referenced this issue Nov 24, 2014
Issue #372 - pagination should use updateModelparams.
cc12da8 
This will likely change once Links are followed.
miketaylr pushed a commit that referenced this issue Nov 24, 2014
Issue #372 - Functional tests for pagination dropdown
acee3a2
miketaylr pushed a commit that referenced this issue Nov 24, 2014
Issue #372 - store "page_limit" key as view object property
8a38322
miketaylr pushed a commit that referenced this issue Nov 24, 2014
Issue #372 - Comment cleanup.
c4058cc
miketaylr pushed a commit that referenced this issue Nov 24, 2014
Issue #372 - jshint fixup
1906209
miketaylr pushed a commit that referenced this issue Nov 24, 2014
Issue #372 - jshint fixup
520961a
miketaylr pushed a commit that referenced this issue Nov 24, 2014
Issue #372 - Functional tests for pagination dropdown
f7321fb
@MaxMood96 MaxMood96 mentioned this issue Jan 12, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Ship full issues page
Development

No branches or pull requests
1 participant
@miketaylr