Skip to content

Implement new anonymous issue creation flow #3139

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
miketaylr opened this issue Jan 9, 2020 · 2 comments
Closed

Implement new anonymous issue creation flow #3139

miketaylr opened this issue Jan 9, 2020 · 2 comments
Assignees
@miketaylr

Comments

@miketaylr
Copy link
Member

miketaylr commented Jan 9, 2020 •
edited
Loading

It may make sense to split this bug up, but keeping together for now because it's all related, and maybe awkward to implement in multiple PRs (maybe not?)

When a user goes to file an anonymous bug:

  1. Create a (public) issue in the web-bugs repository that contains the boilerplate “thanks, we will moderate, feel free to bookmark and check-back” text
  2. Grab the Issue Number of the newly created public and create a private issue in web-bugs-private which associates the public issue number with it somehow. One idea, just store it in the issue body, for example we could re-use our: <!-- @public_url: foo > convention. Or we create a private -> public mapping in a database table.
  3. Make sure this new issue is an a “Unmoderated” milestone, if we’re taking the private GitHub repo shortcut.: See Make sure new private issues are assigned to the "unmoderated" milestone #3146
@miketaylr miketaylr changed the title Implement new anonymous reporting workflow Implement new anonymous issue creation flow Jan 9, 2020
@miketaylr miketaylr self-assigned this Jan 10, 2020
@miketaylr
Copy link
Member Author

(let's see how far I can get)

miketaylr pushed a commit that referenced this issue Jan 10, 2020
Issue #3139 - Add PRIVATE_REPO_URI environment config
d83f872
miketaylr pushed a commit that referenced this issue Jan 10, 2020
Issue #3139 - Make it possible to pass in additional metadata to a form
cec9809
miketaylr pushed a commit that referenced this issue Jan 10, 2020
Issue #3139 - File a private issue for anonymous reporters
2dc4c84 
This first files a public issues, with some placeholder text, then
uses its public URL to add to a private issue's metadata (which contains
the original reporter's data).
@miketaylr
Copy link
Member Author

Make sure this new issue is an a “Unmoderated” milestone, if we’re taking the private GitHub repo shortcut.

I think I'm going to spin this out into a different issue and focus on tests for what I just wrote.

@miketaylr miketaylr mentioned this issue Jan 10, 2020
Closed
miketaylr pushed a commit that referenced this issue Jan 10, 2020
Issue #3139 - File a private issue for anonymous reporters
bf97f50 
This first files a public issues, with some placeholder text, then
uses its public URL to add to a private issue's metadata (which contains
the original reporter's data).
miketaylr pushed a commit that referenced this issue Jan 10, 2020
Issue #3139 - Add tests for extra metadata arg
d715338
miketaylr pushed a commit that referenced this issue Jan 10, 2020
Issue #3139 - Add tests for extra metadata arg
a15e62f
miketaylr pushed a commit that referenced this issue Jan 10, 2020
Issue #3139 - Explicitly return None from report_private_issue
bd3c243 
We don't want to return any info here, let's be explicit.
miketaylr pushed a commit that referenced this issue Jan 10, 2020
Issue #3139 - Add tests for issues.py
43594f0 
They're not amazing, but it's something.
miketaylr pushed a commit that referenced this issue Jan 13, 2020
Issue #3139 - File a private issue for anonymous reporters
6740553 
This first files a public issues, with some placeholder text, then
uses its public URL to add to a private issue's metadata (which contains
the original reporter's data).
miketaylr pushed a commit that referenced this issue Jan 13, 2020
Issue #3139 - Add tests for extra metadata arg
39eb4f1
miketaylr pushed a commit that referenced this issue Jan 13, 2020
Issue #3139 - Explicitly return None from report_private_issue
49eb122 
We don't want to return any info here, let's be explicit.
miketaylr pushed a commit that referenced this issue Jan 13, 2020
Issue #3139 - Add tests for issues.py
589641f 
They're not amazing, but it's something.
miketaylr pushed a commit that referenced this issue Jan 13, 2020
Issue #3139 - Ensure our mock post data returns 201
b8c4e5c
miketaylr pushed a commit that referenced this issue Jan 13, 2020
Issue #3139 - Create a report_public_issue method
bd7f14a
miketaylr pushed a commit that referenced this issue Jan 13, 2020
Issue #3139 - Vastly simplify public_url metadata
e0fd247
miketaylr pushed a commit that referenced this issue Jan 13, 2020
Issue #3139 - Vastly simplify public_url metadata
ea70c9e
miketaylr pushed a commit that referenced this issue Jan 13, 2020
Issue #3139 - Add a add_metadata method
4f2bfa8
miketaylr pushed a commit that referenced this issue Jan 13, 2020
Issue #3139 - Create a report_public_issue method
8c3c68f
miketaylr pushed a commit that referenced this issue Jan 13, 2020
Issue #3139 - Add an add_metadata method
6b655ec 
This allows us to pass in arbitrary metadata keys and values
to be "wrapped" as HTML comments for the issue body
miketaylr pushed a commit that referenced this issue Jan 13, 2020
Issue #3139 - Create a report_public_issue method
d881991
miketaylr pushed a commit that referenced this issue Jan 13, 2020
Issue #3139 - Add an add_metadata method
fff9a49 
This allows us to pass in arbitrary metadata keys and values
to be "wrapped" as HTML comments for the issue body
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@miketaylr miketaylr

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@miketaylr