Skip to content

Update changelog script to account for greenkeeper PRs #2710

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
miketaylr opened this issue Nov 9, 2018 · 2 comments
Closed

Update changelog script to account for greenkeeper PRs #2710

miketaylr opened this issue Nov 9, 2018 · 2 comments
Assignees
@karlcow
Labels
lang: Python scope: build and tooling

Comments

@miketaylr
Copy link
Member

miketaylr commented Nov 9, 2018 •
edited
Loading

Context: Greenkeeper will open PRs for us, that do not correspond to issues, and does not follow our PR formatting guidelines.

For example, #2703

(Perhaps it would be simple to look for a title with a rocket emoji at the end, and special case from there)
@magsout magsout mentioned this issue Nov 12, 2018
Merged
@karlcow
Copy link
Member

karlcow commented Nov 13, 2018

I will work on this, this week!

karlcow added a commit to karlcow/webcompat.com that referenced this issue Nov 14, 2018
@karlcow
Issue webcompat#2710 - Adds support for unicode strings in tests
0d78efd 
GitHub is sending us unicode string. Let's be close to what we receive.
karlcow added a commit to karlcow/webcompat.com that referenced this issue Nov 14, 2018
@karlcow
Issue webcompat#2710 - Adds tests for GreenKeeper format
bdda644
karlcow added a commit to karlcow/webcompat.com that referenced this issue Nov 14, 2018
@karlcow
Issue webcompat#2710 - Adds handling for greenkeeper pull requests
b46df47 
This also now handles the Unicode issue.
@karlcow karlcow mentioned this issue Nov 14, 2018
Merged
@karlcow
Copy link
Member

karlcow commented Nov 14, 2018

ok pull request done. #2712

rafia95 pushed a commit to rafia95/webcompat.com that referenced this issue Nov 21, 2018
@karlcow @rafia95
Issue webcompat#2710 - Adds support for unicode strings in tests
1261868 
GitHub is sending us unicode string. Let's be close to what we receive.
rafia95 pushed a commit to rafia95/webcompat.com that referenced this issue Nov 21, 2018
@karlcow @rafia95
Issue webcompat#2710 - Adds tests for GreenKeeper format
2ee9ac8
rafia95 pushed a commit to rafia95/webcompat.com that referenced this issue Nov 21, 2018
@karlcow @rafia95
Issue webcompat#2710 - Adds handling for greenkeeper pull requests
9c51952 
This also now handles the Unicode issue.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@karlcow karlcow

Labels
lang: Python scope: build and tooling
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@miketaylr @karlcow