Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: issues #271

Closed
miketaylr opened this issue Sep 17, 2014 · 9 comments
Closed

tests: issues #271

miketaylr opened this issue Sep 17, 2014 · 9 comments

Comments

@miketaylr
Copy link
Member

need to test:

  • closing an issue
  • re-opening an issue
  • buttons are disabled/enabled appropriately
  • buttons have expected text
karlcow added a commit to karlcow/webcompat.com that referenced this issue Sep 18, 2014
karlcow added a commit to karlcow/webcompat.com that referenced this issue Sep 18, 2014
@karlcow
Copy link
Member

karlcow commented Sep 18, 2014

In the current master branch it doesn't work.
Does it have to be tested against dev.webcompat.com for now.

Trying to understand what the tests are about and creating a first pull request for the first two bullet points.

@karlcow
Copy link
Member

karlcow commented Sep 18, 2014

On webcompat.com and my local instance. The buttons are disabled and I don't know why :) or at least they are not working.

karlcow added a commit to karlcow/webcompat.com that referenced this issue Sep 18, 2014
@karlcow
Copy link
Member

karlcow commented Sep 18, 2014

Hmm not sure when the buttons are expected to be disabled/enabled. @calexity and @miketaylr ?

@calexity
Copy link
Contributor

On an individual issue -

  • given that a user is logged in, "Close issue" should be always enabled
  • given that a user is logged in, "Comment" should be disabled by default
  • given that a user is logged in and that there is text in the Comment field, "Comment" should be enabled

@miketaylr is that right?

@miketaylr
Copy link
Member Author

On webcompat.com and my local instance. The buttons are disabled and I don't know why :) or at least they are not working.

That's because when we ditched Bootstrap we missed converting over some of the CSS classes we were using in the JS. I think. ^_^ It's fixed on staging, so I'll go ahead and deploy to production.

@miketaylr
Copy link
Member Author

@calexity yep, exactly.

@miketaylr
Copy link
Member Author

  • buttons are disabled/enabled appropriately
  • buttons have expected text

These two tests were covered by the first two tests @ be5f03d

@miketaylr
Copy link
Member Author

@karlcow do you have plans to update the tests you've already written? If not, I'd like to take this bug.

@miketaylr miketaylr self-assigned this Dec 23, 2014
@miketaylr
Copy link
Member Author

Talking with Karl in IRC, I'm going to take this over.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants