Skip to content

Update ua-parser to 0.8 #2437

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
miketaylr opened this issue May 1, 2018 · 1 comment
Closed

Update ua-parser to 0.8 #2437

miketaylr opened this issue May 1, 2018 · 1 comment
Assignees
@karlcow
Labels
lang: Python
Milestone
April / May / Jun...

Comments

@miketaylr
Copy link
Member

A new version is out: https://github.com/ua-parser/uap-python
@miketaylr miketaylr added this to the April / May / June 2018 milestone May 1, 2018
@karlcow
Copy link
Member

karlcow commented May 9, 2018

Let's see what does it bring.

ua-parser/uap-python@0.7.2...master

Mostly fixing a test bug and updating to latest versions of python, which is good for us for moving to python 3.6

→ pip install -r config/requirements.txt 
Requirement already satisfied: blinker==1.4 in /Users/karl/.virtualenvs/webcompatcom/lib/python2.7/site-packages (from -r config/requirements.txt (line 1))
Requirement already satisfied: Flask==0.12 in /Users/karl/.virtualenvs/webcompatcom/lib/python2.7/site-packages (from -r config/requirements.txt (line 2))
Requirement already satisfied: Flask-Limiter==0.9.3 in /Users/karl/.virtualenvs/webcompatcom/lib/python2.7/site-packages (from -r config/requirements.txt (line 3))
Requirement already satisfied: Flask-SQLAlchemy==2.1 in /Users/karl/.virtualenvs/webcompatcom/lib/python2.7/site-packages (from -r config/requirements.txt (line 4))
Requirement already satisfied: Flask-WTF==0.14.2 in /Users/karl/.virtualenvs/webcompatcom/lib/python2.7/site-packages (from -r config/requirements.txt (line 5))
Requirement already satisfied: GitHub-Flask==3.1.5 in /Users/karl/.virtualenvs/webcompatcom/lib/python2.7/site-packages (from -r config/requirements.txt (line 6))
Requirement already satisfied: mock==2.0.0 in /Users/karl/.virtualenvs/webcompatcom/lib/python2.7/site-packages (from -r config/requirements.txt (line 7))
Requirement already satisfied: nose==1.3.7 in /Users/karl/.virtualenvs/webcompatcom/lib/python2.7/site-packages (from -r config/requirements.txt (line 8))
Requirement already satisfied: pep8==1.7.0 in /Users/karl/.virtualenvs/webcompatcom/lib/python2.7/site-packages (from -r config/requirements.txt (line 9))
Requirement already satisfied: Pillow==4.0.0 in /Users/karl/.virtualenvs/webcompatcom/lib/python2.7/site-packages (from -r config/requirements.txt (line 10))
Requirement already satisfied: requests==2.13.0 in /Users/karl/.virtualenvs/webcompatcom/lib/python2.7/site-packages (from -r config/requirements.txt (line 11))
Collecting ua-parser==0.8 (from -r config/requirements.txt (line 12))
  Downloading https://files.pythonhosted.org/packages/10/24/b13d43fbdc69b324be35058ee67e7c570ca728737bc37eadf92fa4668812/ua_parser-0.8.0-py2.py3-none-any.whl
Requirement already satisfied: WTForms==2.1 in /Users/karl/.virtualenvs/webcompatcom/lib/python2.7/site-packages (from -r config/requirements.txt (line 13))
Requirement already satisfied: Jinja2>=2.4 in /Users/karl/.virtualenvs/webcompatcom/lib/python2.7/site-packages (from Flask==0.12->-r config/requirements.txt (line 2))
Requirement already satisfied: Werkzeug>=0.7 in /Users/karl/.virtualenvs/webcompatcom/lib/python2.7/site-packages (from Flask==0.12->-r config/requirements.txt (line 2))
Requirement already satisfied: click>=2.0 in /Users/karl/.virtualenvs/webcompatcom/lib/python2.7/site-packages (from Flask==0.12->-r config/requirements.txt (line 2))
Requirement already satisfied: itsdangerous>=0.21 in /Users/karl/.virtualenvs/webcompatcom/lib/python2.7/site-packages (from Flask==0.12->-r config/requirements.txt (line 2))
Requirement already satisfied: limits in /Users/karl/.virtualenvs/webcompatcom/lib/python2.7/site-packages (from Flask-Limiter==0.9.3->-r config/requirements.txt (line 3))
Requirement already satisfied: six>=1.4.1 in /Users/karl/.virtualenvs/webcompatcom/lib/python2.7/site-packages (from Flask-Limiter==0.9.3->-r config/requirements.txt (line 3))
Requirement already satisfied: SQLAlchemy>=0.7 in /Users/karl/.virtualenvs/webcompatcom/lib/python2.7/site-packages (from Flask-SQLAlchemy==2.1->-r config/requirements.txt (line 4))
Requirement already satisfied: pbr>=0.11 in /Users/karl/.virtualenvs/webcompatcom/lib/python2.7/site-packages (from mock==2.0.0->-r config/requirements.txt (line 7))
Requirement already satisfied: funcsigs>=1; python_version < "3.3" in /Users/karl/.virtualenvs/webcompatcom/lib/python2.7/site-packages (from mock==2.0.0->-r config/requirements.txt (line 7))
Requirement already satisfied: olefile in /Users/karl/.virtualenvs/webcompatcom/lib/python2.7/site-packages (from Pillow==4.0.0->-r config/requirements.txt (line 10))
Requirement already satisfied: MarkupSafe>=0.23 in /Users/karl/.virtualenvs/webcompatcom/lib/python2.7/site-packages (from Jinja2>=2.4->Flask==0.12->-r config/requirements.txt (line 2))
Installing collected packages: ua-parser
  Found existing installation: ua-parser 0.7.2
    Uninstalling ua-parser-0.7.2:
      Successfully uninstalled ua-parser-0.7.2
Successfully installed ua-parser-0.8.0

Then nosetests

→ nosetests
........................................................................................
----------------------------------------------------------------------
Ran 88 tests in 3.103s

OK

karlcow added a commit to karlcow/webcompat.com that referenced this issue May 9, 2018
@karlcow
Issue webcompat#2437 - Upgrades python ua-parser version to 0.8
fd8c65e
@karlcow karlcow self-assigned this May 9, 2018
@karlcow karlcow mentioned this issue May 9, 2018
Merged
karlcow added a commit to karlcow/webcompat.com that referenced this issue May 9, 2018
@karlcow
Issue webcompat#2437 - Adds tests for rendering wrt addons
13306b9 
This does two things:
- Adds unittest tests to check that the right partial template for addons is sent depending on the user agent string.
- Adds a test for an unknown browser
- Fixes the template for addon where some white spaces where left over here and there.
- Removes the previous weaker functional tests which was very dependent on the testing browser.

It was triggered by the upgrade of ua-parser in python which took into account the headlesschrome user agent string, then not detected by our template. It was making the functional test fail.
See webcompat#2444 for the background.
karlcow added a commit to karlcow/webcompat.com that referenced this issue May 10, 2018
@karlcow
Issue webcompat#2437 - Adds tests for rendering wrt addons
c9c4f76 
This does two things:
- Adds unittest tests to check that the right partial template for addons is sent depending on the user agent string.
- Adds a test for an unknown browser
- Fixes the template for addon where some white spaces where left over here and there.
- Removes the previous weaker functional tests which was very dependent on the testing browser.

It was triggered by the upgrade of ua-parser in python which took into account the headlesschrome user agent string, then not detected by our template. It was making the functional test fail.
See webcompat#2444 for the background.
karlcow added a commit to karlcow/webcompat.com that referenced this issue May 10, 2018
@karlcow
Issue webcompat#2437 - Adds tests for rendering wrt addons
f0b60d3 
This does two things:
- Adds unittest tests to check that the right partial template for addons is sent depending on the user agent string.
- Adds a test for an unknown browser
- Fixes the template for addon where some white spaces where left over here and there.
- Removes the previous weaker functional tests which was very dependent on the testing browser.

It was triggered by the upgrade of ua-parser in python which took into account the headlesschrome user agent string, then not detected by our template. It was making the functional test fail.
See webcompat#2444 for the background.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@karlcow karlcow

Labels
lang: Python
Projects
None yet
Milestone
April / May / June 2018
Development

No branches or pull requests
2 participants
@miketaylr @karlcow