Skip to content

Fix for alexa topsite deployment #1726

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
MDTsai opened this issue Aug 25, 2017 · 2 comments
Closed

Fix for alexa topsite deployment #1726

MDTsai opened this issue Aug 25, 2017 · 2 comments

Comments

@MDTsai
Copy link
Contributor

MDTsai commented Aug 25, 2017

  • Fix to use HTTPS instead of HTTP
  • Adjust the parameter sequence, origin move AWSAccessKeyId to first

@miketaylr ,do we need to read the key from config or keep using in argument?

@miketaylr
Copy link
Member

If we're running as cronjob, using as an argument seems fine (and reduces risk of leaking key). We could also store the key as an environment variable on the server and have the config read from that.

What do you think is better?

@MDTsai
Copy link
Contributor Author

MDTsai commented Aug 30, 2017

Agree with cronjob with key in arguments. There is no more change need, I will send PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants