Skip to content

Add test for /activity/user #1428

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
heatherbooker opened this issue Mar 17, 2017 · 1 comment
Closed

Add test for /activity/user #1428

heatherbooker opened this issue Mar 17, 2017 · 1 comment
Assignees
@karlcow
Labels
status: in progress type: site-development type: testing

Comments

@heatherbooker
Copy link
Contributor

To finish up #1419 (fixes #1412 ), there needs to be one more title added to the array being tested in test_rendering.py - the title for /activity/user. This will require mocking the circumstances of the /activity template. More info here.
@heatherbooker heatherbooker mentioned this issue Mar 17, 2017
Merged
@karlcow karlcow self-assigned this Mar 17, 2017
karlcow added a commit to karlcow/webcompat.com that referenced this issue Mar 23, 2017
@karlcow
webcompat#1428 Removes unused import
80a4ed9
karlcow added a commit to karlcow/webcompat.com that referenced this issue Mar 23, 2017
@karlcow
webcompat#1428 Fixes lass name and defines setUp
aca4b73
karlcow added a commit to karlcow/webcompat.com that referenced this issue Mar 23, 2017
@karlcow
webcompat#1428 - Modifies before_request for testing
97d1ef8
karlcow added a commit to karlcow/webcompat.com that referenced this issue Mar 23, 2017
@karlcow
webcompat#1428 - Adds test for personal activity route
e2ffeaa
karlcow added a commit to karlcow/webcompat.com that referenced this issue Mar 23, 2017
@karlcow
webcompat#1428 - Handles the notion of session in the tests
bf44206
@karlcow
Copy link
Member

karlcow commented Mar 23, 2017

Tests in test_rendering are working and correctly check /activity/username template… BUT to be able to make it work correctly I had to modified a bit views.py
which in return broke almost all tests in test_urls.py 😂

I changed a bit the way we do test_urls.py and went from all to two tests breaking. 1 ERROR and 1 FAILURE. I have hope. :)

Mostly related to the fact that these tests are calling… GitHub when a username is given. So I need to find a better way of managing side effects. And probably at the same time, if I find an elegant solution that would make #1384 a lot easier to implement.

Suggestions are welcome. I wonder if @vladikoff has one idea or two. Or if I'm doing it really wrong.

karlcow added a commit to karlcow/webcompat.com that referenced this issue Aug 25, 2017
@karlcow
Issue webcompat#1428 - Fix syntax according to webcompat#1473
b8082e7
karlcow added a commit to karlcow/webcompat.com that referenced this issue Aug 25, 2017
@karlcow
Issue webcompat#1428 - Adds test for activity page
5e0ae5d
karlcow added a commit to karlcow/webcompat.com that referenced this issue Aug 29, 2017
@karlcow
Issue webcompat#1428 - Adds test for activity page
a54c1e7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@karlcow karlcow

Labels
status: in progress type: site-development type: testing
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@karlcow @heatherbooker