Skip to content

accepting windows backslash paths #53459

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

accepting windows backslash paths #53459

wants to merge 4 commits into from

Conversation

mertcanaltin
Copy link

@wpt-pr-bot wpt-pr-bot added the url label Jun 28, 2025
@domenic
Copy link
Member

domenic commented Jun 29, 2025

You should update urltestdata.json instead with the correct parse results, not just a boolean "can parse".

Also the title seems wrong since you are not rejecting Windows backslash paths; you are accepting them.

@mertcanaltin mertcanaltin changed the title Reject windows backslash paths accepting windows backslash paths Jun 29, 2025
@mertcanaltin
Copy link
Author

Thanks for review, I will applied your says

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@annevk annevk Awaiting requested review from annevk

@domenic domenic Awaiting requested review from domenic

@mikewest mikewest Awaiting requested review from mikewest

@TimothyGu TimothyGu Awaiting requested review from TimothyGu

At least 1 approving review is required to merge this pull request.

Assignees

@domenic domenic

Labels
url
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mertcanaltin @domenic @wpt-pr-bot