Add test_driver.bidi.bluetooth commands and event #53204
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
added
docs
infra
testdriver.js
webdriver
webdriver-bidi
wg-s_browser-tools-testing
wptrunner
wpt-pr-bot
requested review from
AutomatedTester,
DanielRyanSmith,
foolip,
jgraham,
jonathan-j-lee,
juliandescottes,
sadym-chromium,
shs96c,
sideshowbarker and
whimboo
|
PTAL. The failure in https://github.com/web-platform-tests/wpt/pull/53204/checks?check_run_id=44241981837 should be fixed once https://chromium-review.googlesource.com/c/chromium/src/+/6650787 is available in canary. |
webdriver/tests/bidi/external/bluetooth/simulate_service/simulate_service.py
Outdated
Show resolved
Hide resolved
sadym-chromium
approved these changes
Jun 18, 2025
sadym-chromium
approved these changes
Jun 18, 2025
There was a problem hiding this comment.
Some minor comments + please make sure the CI passes, as https://crrev.com/c/6650787 is landed in "139.0.7245.0"
|
@foolip could you please review and merge the PR? |
|
@jcscottiii PTAL, as @foolip is OOO |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the following WebDriver BiDi commands and event and extend the documentation:
test_driver.bidi.bluetooth.simulate_servicemethod matchingbluetooth.simulateServicetest_driver.bidi.bluetooth.simulate_characteristicmethod matchingbluetooth.simulateCharacteristictest_driver.bidi.bluetooth.simulate_characteristic_responsemethod matchingbluetooth.simulateCharacteristicResponsetest_driver.bidi.bluetooth.simulate_descriptormethod matchingbluetooth.simulateDescriptortest_driver.bidi.bluetooth.simulate_descriptor_responsemethod matchingbluetooth.simulateDescriptorResponsetest_driver.bidi.bluetooth.characteristic_event_generatedmethod matchingbluetooth.ChracteristicEventGeneratedtest_driver.bidi.bluetooth.descriptor_event_generatedmethod matchingbluetooth.DescriptorEventGenerated