Skip to content

Enable site isolation for headless shell #49605

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Dec 10, 2024
Merged

Enable site isolation for headless shell #49605

merged 3 commits into from
Dec 10, 2024

Conversation

WeizhongX
Copy link
Contributor

Site isolation is disabled by default in headless shell. Enable that through testrunner unless that is explicitly disabled.

This turns on SiteIsolation in headless shell by default, if that is not
explicitly disabled through flag specific config or VTS.

Bug: None
@wpt-pr-bot wpt-pr-bot added infra wptrunner The automated test runner, commonly called through ./wpt run labels Dec 9, 2024
Copy link

Uh oh! Looks like an error!

Client ID static/taskcluster/github does not have sufficient scopes and is missing the following scopes:

{
  "AnyOf": [
    "queue:rerun-task:taskcluster-github/ZlESXRiRRQmMCspCfS96Jw/G-tz052ERjOnqHDu1Wb3WA",
    "queue:rerun-task-in-project:none",
    {
      "AllOf": [
        "queue:rerun-task",
        "assume:scheduler-id:taskcluster-github/ZlESXRiRRQmMCspCfS96Jw"
      ]
    }
  ]
}

This request requires the client to satisfy the following scope expression:

{
  "AnyOf": [
    "queue:rerun-task:taskcluster-github/ZlESXRiRRQmMCspCfS96Jw/G-tz052ERjOnqHDu1Wb3WA",
    "queue:rerun-task-in-project:none",
    {
      "AllOf": [
        "queue:rerun-task",
        "assume:scheduler-id:taskcluster-github/ZlESXRiRRQmMCspCfS96Jw"
      ]
    }
  ]
}

  • method: rerunTask
  • errorCode: InsufficientScopes
  • statusCode: 403
  • time: 2024-12-10T16:58:01.931Z

@WeizhongX
Copy link
Contributor Author

This failure is due to #49545.

@KyleJu @jcscottiii can you help admin merge? Thanks!

@KyleJu KyleJu merged commit bc62de4 into master Dec 10, 2024
31 of 33 checks passed
@KyleJu KyleJu deleted the enable-site-isolation branch December 10, 2024 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
infra wptrunner The automated test runner, commonly called through ./wpt run
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants