Skip to content

ci: another round of adjustments to release-please configuration #5055

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 7, 2025

Conversation

erikgb
Copy link
Contributor

@erikgb erikgb commented Jun 7, 2025

Closes

What changed?

The main change in this PR, is to configure release-please to create separate release PRs per package (app and Helm). The grouped release PR (#4870) is wrong, and I haven't found a way to fix it. So I will attempt to create a more suboptimal workflow that actually does things right.

Why was this change made?

Because of a buggy grouped release PR, see https://github.com/weaveworks/weave-gitops/pull/4870/files#r2118236318.

How was this change implemented?

How did you validate the change?

Release notes

Documentation Changes

@erikgb erikgb requested review from casibbald and a team June 7, 2025 15:04
@erikgb erikgb force-pushed the release-please-adjustments branch from 68e2faf to f820d10 Compare June 7, 2025 15:04
@erikgb erikgb enabled auto-merge (squash) June 7, 2025 15:05
Copy link
Collaborator

@casibbald casibbald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@erikgb erikgb merged commit b82bad9 into weaveworks:main Jun 7, 2025
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants