Skip to content

ci(lint): enable @typescript-eslint/ban-ts-comment eslint rule #4566

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 19, 2025
Merged

ci(lint): enable @typescript-eslint/ban-ts-comment eslint rule #4566

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion eslint.config.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,6 @@ export default tseslint.config([
}
],
"@typescript-eslint/no-explicit-any": 0,
"@typescript-eslint/ban-ts-comment": 0,
"import/no-named-as-default": 0,
"@typescript-eslint/switch-exhaustiveness-check": [2,
{
Expand Down
2 changes: 0 additions & 2 deletions ui/lib/__tests__/graph.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -151,7 +151,6 @@ describe("graph lib", () => {
};

const objects2 = await getChildren(
// @ts-ignore
newClient,
app.name,
app.namespace,
Expand Down Expand Up @@ -198,7 +197,6 @@ describe("graph lib", () => {
};

const objects2 = await getChildren(
// @ts-ignore
newClient,
app.name,
app.namespace,
Expand Down
8 changes: 4 additions & 4 deletions ui/lib/fonts.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,12 +1,12 @@
import { createGlobalStyle } from "styled-components";
// Typescript will handle type-checking/linting for this file
// @ts-ignore
// @ts-expect-error TODO
import ProximaNovaBold from "url:../fonts/ProximaNovaBold.otf";
// @ts-ignore
// @ts-expect-error TODO
import ProximaNovaRegular from "url:../fonts/ProximaNovaRegular.otf";
// @ts-ignore
// @ts-expect-error TODO
import ProximaNovaSemibold from "url:../fonts/ProximaNovaSemibold.otf";
// @ts-ignore
// @ts-expect-error TODO
import robotomono from "url:../fonts/roboto-mono-regular.woff";

const Fonts = createGlobalStyle`
Expand Down
2 changes: 1 addition & 1 deletion ui/lib/test-utils.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,7 @@ export function withContext(
});
const isElement = React.isValidElement(TestComponent);
window.matchMedia = jest.fn();
//@ts-ignore
//@ts-expect-error TODO
window.matchMedia.mockReturnValue({ matches: false });
return (
<Router location={url} navigator={history}>
Expand Down
Loading