Disable scope hoisting for production #4529
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gusevda
force-pushed
the
parcel-build-issue
branch
from
e8cabff to
7880360
Compare
casibbald
approved these changes
Jan 15, 2025
This was referenced Jan 26, 2025
This was referenced Feb 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Parcel scope hoisting was temporarily disabled.
Why was this change made?
Currently there is a problem with production build. No errors during build time, but in a browser there is an error in JS console. And as a result, no UI is being rendered.
The error:
Cause of the issue is the recent Parcel configuration change. Package exports support was enabled and alias for
yamlpackage was deleted. It works as expected,yamland other packages that haveexportsin theirpackage.jsonare being resolved correctly, but Parcel's scope hoisting breaks production builds. Further investigation is needed, but as a temporal solution, hoisting was disabled in this PR.