Skip to content

Remove react-router-dom from dependencies and mark it ignored #4493

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

mproffitt
Copy link
Contributor

Closes

What changed?

Dependabot ignore changes to react-router-dom

Why was this change made?

react-router-dom is removed in react-router >= 7 and requires a more extensive rework to upgrade to react-router

How was this change implemented?

How did you validate the change?

Release notes

Documentation Changes

@mproffitt mproffitt requested a review from erikgb January 12, 2025 11:53
Copy link
Contributor

@erikgb erikgb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mproffitt mproffitt merged commit e4d6f2f into weaveworks:main Jan 12, 2025
13 checks passed
This was referenced Jan 15, 2025
This was referenced Feb 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants