Skip to content

chore: cleanup ESLint config file #4487

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 11, 2025
Merged

Conversation

erikgb
Copy link
Contributor

@erikgb erikgb commented Jan 10, 2025

Closes

What changed?

  • Cleaned out explicitly disabled rules with no current violations.
  • Make config more consistent (2 vs. error).
  • Updated the language setting after Typescrpt target bumped to ES2018

Why was this change made?

Cleaner and more consistent configuration.

How was this change implemented?

How did you validate the change?

Release notes

Documentation Changes

@erikgb erikgb enabled auto-merge January 10, 2025 23:01
Copy link
Contributor

@gusevda gusevda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@erikgb erikgb force-pushed the fix-eslint-config branch from 4063dfa to 83e85f4 Compare January 11, 2025 08:58
@erikgb erikgb force-pushed the fix-eslint-config branch from 83e85f4 to 31c5875 Compare January 11, 2025 08:59
@erikgb erikgb merged commit 714c09c into weaveworks:main Jan 11, 2025
13 checks passed
This was referenced Jan 15, 2025
This was referenced Feb 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants