fix: call to logger with odd number of key/value params

[erikgb]

Closes #4193

What changed?

Fix bug with odd number of key/value pairs sent to logger. There is already an open PR to fix this, but we got no response from the author: #4193.

I am also adding a linter to avoid this from happening again: https://github.com/timonwong/loggercheck

Without fixing the bug, but enabling the new linter, it fails:

$ make lint
/home/erikbo/projects/github/weave-gitops/bin/golangci-lint run
core/server/inventory.go:290:74: odd number of arguments passed as key-value pairs for logging (loggercheck)
                                                logger.Error(err, "failed to determine if %s is namespace scoped", obj.GetObjectKind().GroupVersionKind().Kind)
                                                                                                                   ^
make: *** [Makefile:113: lint] Error 1

Why was this change made?

Bugfix to avoid panic if attempting to log from here..

How was this change implemented?

How did you validate the change?

Release notes

Documentation Changes