Skip to content

ci: init new workflow to build images #4468

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 9, 2025

Conversation

erikgb
Copy link
Contributor

@erikgb erikgb commented Jan 8, 2025

Closes

What changed?

This replaces the image-build jobs in the PR workflow. We need to find a new home for our images anyway, and GHCR seems like our best option. After merging this PR, we should expect images pushed to our GHCR with the default branch name tag (main).

Future work:

  • Review dockerfiles with regards to caching. I have a feeling that it's not optimal now. I would expect better performance, but appears to be an improvement already now.
  • Add keyless signature to images using Cosign.

Why was this change made?

Prepare CI for our first community release.

How was this change implemented?

How did you validate the change?

Release notes

Documentation Changes

@erikgb erikgb marked this pull request as ready for review January 8, 2025 22:11
@erikgb erikgb requested a review from casibbald January 8, 2025 22:11
@erikgb erikgb force-pushed the new-image-build-workflow branch from 2ec2522 to 79ff09b Compare January 9, 2025 07:45
@casibbald casibbald merged commit 62b675f into weaveworks:main Jan 9, 2025
18 checks passed
casibbald added a commit that referenced this pull request Jan 9, 2025
This was referenced Jan 15, 2025
This was referenced Feb 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants