Skip to content

fix: clean up inefficient resolutions #4440

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 5, 2025

Conversation

erikgb
Copy link
Contributor

@erikgb erikgb commented Jan 5, 2025

Closes

What changed?

An attempt to clean up yarn "resolutions" as much as possible. Hopefully this change won't break anything. I wonder why @casibbald locked commander to version 11.0.0 in #4258, and not the latest version?

Why was this change made?

The initial motivation was this Dependabot error:

Dependabot encountered '1' error(s) during execution, please check the logs for more details.
+-------------------------------+
| Dependencies failed to update |
+---------------+---------------+
| commander     | unknown_error |
+---------------+---------------+
Failure running container a34eb083ffc9c00a60c42dd811a8aeec342944b5d2345b3eb26461f3002bd78d
Cleaned up container a34eb083ffc9c00a60c42dd811a8aeec342944b5d2345b3eb26461f3002bd78d
  proxy | 2025/01/04 15:37:54 89/254 calls cached (35%)
2025/01/04 15:37:54 Posting metrics to remote API endpoint
Error: Dependabot encountered an error performing the update

Error: The updater encountered one or more errors.

Example: https://github.com/weaveworks/weave-gitops/actions/runs/12611701754/job/35147629886

But in general we should follow up on the "resolutions" element closely. It could easily become a source of upgrade errors.

How was this change implemented?

How did you validate the change?

Release notes

Documentation Changes

@erikgb erikgb requested review from casibbald and tenstad January 5, 2025 18:22
@erikgb erikgb marked this pull request as ready for review January 5, 2025 18:37
@erikgb erikgb enabled auto-merge January 5, 2025 18:37
@erikgb erikgb merged commit 87381e9 into weaveworks:main Jan 5, 2025
19 checks passed
This was referenced Jan 15, 2025
This was referenced Feb 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants