Skip to content

fix: clashing httptest ports #4553

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 17, 2025

Conversation

casibbald
Copy link
Collaborator

Closes

What changed?

Why was this change made?

How was this change implemented?

How did you validate the change?

Release notes

Documentation Changes

Copy link
Contributor

@erikgb erikgb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Thanks!

@erikgb
Copy link
Contributor

erikgb commented Jan 16, 2025

This workflow happened to find a conflicting port: https://github.com/weaveworks/weave-gitops/actions/runs/12816199237/job/35736576413

@casibbald casibbald force-pushed the fix-clashing-test-ports branch from fcee309 to 3c554ff Compare January 17, 2025 07:35
@casibbald casibbald merged commit fdb4c16 into weaveworks:main Jan 17, 2025
13 checks passed
@casibbald casibbald deleted the fix-clashing-test-ports branch January 17, 2025 07:44
This was referenced Feb 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants