Skip to content

Fix some problems related to IT Hygiene #7461

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
May 29, 2025

Conversation

Desvelao
Copy link
Member

@Desvelao Desvelao commented May 26, 2025

Description

This pull request

Changes

  • Remove Arhitecture selector from System > Hardware
  • Remove package.architecture as default column in Packages > Packages
  • Replace States viualization ain IT Hygiene > Dashboard and Processes > Processses
  • Fix visualization of Global packets loss rate

Issues Resolved

#7450

Evidence

image
image
image
image
image

Test

wdp-pr-7461

Legend:
⚫: none
🟢: pass
🟡: warning
🔴: fail
⚪: not applicable

UI

Test Chrome Firefox Safari
Ensure there is no Arhitecture selector in System > Hardware
Ensure the package.architecture field is not set as default column in of the table in Packages > Packages
Ensure the visualization of Global packets loss rate represents the expected value and has no too much decimals

Details

⚫ Ensure there is no Arhitecture selector in System > Hardware

Chrome - ⚫

Firefox - ⚫

Safari - ⚫

⚫ Ensure the package.architecture field is not set as default column in of the table in Packages > Packages

Chrome - ⚫

Firefox - ⚫

Safari - ⚫

⚫ Ensure the visualization of Global packets loss rate represents the expected value and has no too much decimals

Chrome - ⚫

Firefox - ⚫

Safari - ⚫

Check List

  • All tests pass
    • yarn test:jest
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

@Desvelao Desvelao self-assigned this May 26, 2025
@Desvelao Desvelao linked an issue May 26, 2025 that may be closed by this pull request
6 tasks
@Desvelao Desvelao marked this pull request as ready for review May 26, 2025 12:37
@yenienserrano yenienserrano self-requested a review May 26, 2025 12:43
@yenienserrano
Copy link
Member

yenienserrano commented May 26, 2025

Test

wdp-pr-7461

Legend:
⚫: none
🟢: pass
🟡: warning
🔴: fail
⚪: not applicable

UI

Test Chrome Firefox Safari
Ensure there is no Arhitecture selector in System > Hardware 🟢 🟢 🟢
Ensure the package.architecture field is not set as default column in of the table in Packages > Packages 🟢 🟢 🟢
Ensure the visualization of Global packets loss rate represents the expected value and has no too much decimals 🟢 🟢 🟢

Details

🟢 Ensure there is no Architecture selector in System > Hardware

Chrome - 🟢

image

Firefox - 🟢

image

Safari - 🟢

image
🟢 Ensure the package.architecture field is not set as default column in of the table in Packages > Packages

Chrome - 🟢

image

Firefox - 🟢

image

Safari - 🟢

image
🟢 Ensure the visualization of Global packets loss rate represents the expected value and has no too much decimals

Chrome - 🟢

image

Firefox - 🟢

image

Safari - 🟢

image

@guidomodarelli
Copy link
Contributor

guidomodarelli commented May 26, 2025

Test

Legend:
⚫ => The test hasn't started yet.
🟢 => All checks passed.
🟡 => There is at least one expected fail or skipped test and no failures.
🔴 => There is at least one failed check.
⚪ => Doesn't apply.
🔧 => Request changes.
❓ => Needs more information.

UI

Test Chrome Firefox
Ensure there is no Arhitecture selector in System > Hardware 🟢 🟢
Ensure the package.architecture field is not set as default column in of the table in Packages > Packages 🟢 🟢
Ensure the visualization of Global packets loss rate represents the expected value and has no too much decimals 🟢 🟢
Make sure that Process Initiation exists under IT Hygiene > Processes > Processes and under **IT Hygiene > Dashboard and that it is a chart. 🟢 🟢

Details

🟢 Ensure there is no Architecture selector in System > Hardware

CHROME - 🟢

image

FIREFOX - 🟢

image

🟢 Ensure the package.architecture field is not set as default column in of the table in Packages > Packages

CHROME - 🟢

image

FIREFOX - 🟢

image

🟢 Ensure the visualization of Global packets loss rate represents the expected value and has no too much decimals

CHROME - 🟢

image

FIREFOX - 🟢

image

🟢 Make sure that **Process Initiation** exists under **IT Hygiene > Processes > Processes** and under **IT Hygiene > Dashboard and that it is a **chart**.

CHROME - 🟢

image

image

FIREFOX - 🟢

image

image

guidomodarelli
guidomodarelli previously approved these changes May 26, 2025
Copy link
Contributor

@guidomodarelli guidomodarelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Legend:
⚫ => The test hasn't started yet.
🟢 => All checks passed.
🟡 => There is at least one expected fail or skipped test and no failures.
🔴 => There is at least one failed check.
⚪ => Doesn't apply.
🔧 => Request changes.
❓ => Needs more information.

🧪 Test 2025/05/26

CR 🟢
TEST 🟢

@Desvelao Desvelao changed the title Fix some problems realted to IT Hygiene Fix some problems related to IT Hygiene May 26, 2025
Copy link
Contributor

Wazuh Check Updates plugin code coverage (Jest) test % values
Statements 78.72% ( 185 / 235 )
Branches 62.72% ( 69 / 110 )
Functions 61.7% ( 29 / 47 )
Lines 78.72% ( 185 / 235 )

Copy link
Contributor

Wazuh Core plugin code coverage (Jest) test % values
Statements 47.61% ( 439 / 922 )
Branches 41.09% ( 157 / 382 )
Functions 45.89% ( 151 / 329 )
Lines 47.81% ( 437 / 914 )

Copy link
Contributor

@guidomodarelli guidomodarelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🟢

Copy link
Contributor

Main plugin code coverage (Jest) test % values
Statements 16.34% ( 4940 / 30219 )
Branches 10.4% ( 1998 / 19197 )
Functions 17.46% ( 1288 / 7375 )
Lines 16.59% ( 4828 / 29101 )

Copy link
Member

@yenienserrano yenienserrano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR: 🟢
Test: 🟢

@asteriscos asteriscos merged commit d21cf33 into 4.13.0 May 29, 2025
5 checks passed
@asteriscos asteriscos deleted the bug/7450-global-queries-problems branch May 29, 2025 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bugs found in global queries
4 participants