Skip to content

Change the agent startup command in macOS #7430

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

yenienserrano
Copy link
Member

@yenienserrano yenienserrano commented May 9, 2025

Description

The agent start command is changed so that it is synchronized with the documentation and does not give errors when uninstalling the agent.

Issues Resolved

Evidence

image

Test

  1. Installing a macOS agent using the agent registration wizard
  2. Follow the uninstallation guide of the agent https://documentation.wazuh.com/current/installation-guide/uninstalling-wazuh/agent.html#uninstalling-macos-agent
  3. The agent must be deleted

Check List

  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

The previous command used `wazuh-control start`, which is deprecated. The new command uses `launchctl load` to properly start the Wazuh agent as a macOS service.
@yenienserrano yenienserrano self-assigned this May 9, 2025
@yenienserrano yenienserrano linked an issue May 9, 2025 that may be closed by this pull request
@yenienserrano yenienserrano marked this pull request as ready for review May 9, 2025 18:35
gonzaarancibia
gonzaarancibia previously approved these changes May 9, 2025
Copy link
Member

@gonzaarancibia gonzaarancibia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Legend:
⚫ => The test hasn't started yet.
🟢 => All checks passed.
🟡 => There is at least one expected fail or skipped test and no failures.
🔴 => There is at least one failed check.
⚪ => Doesn't apply.
🔧 => Request changes.
❓ => Needs more information.

🧪 Test 2025/05/09
CR 🟢
TEST 🟢

Screen.Recording.2025-05-09.at.5.55.41.PM.mov
Screenshot 2025-05-09 at 6 02 48 PM Screenshot 2025-05-09 at 6 03 16 PM Screenshot 2025-05-09 at 6 03 28 PM Screenshot 2025-05-09 at 6 12 18 PM

CHANGELOG.md Outdated
@@ -24,6 +24,7 @@ All notable changes to the Wazuh app project will be documented in this file.
### Changed

- Refined queue usage visualizations in Statistics [#7192](https://github.com/wazuh/wazuh-dashboard-plugins/pull/7192)
- Changed macOS agent startup command [#7430](https://github.com/wazuh/wazuh-dashboard-plugins/pull/7430)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changelog was added in 4.12.0 version. It has to be added in 4.12.1. Please fix this.

Copy link
Member

@asteriscos asteriscos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🟢

screencapture-localhost-5601-app-endpoints-summary-2025-05-13-12_56_17

Copy link
Contributor

Wazuh Check Updates plugin code coverage (Jest) test % values
Statements 78.72% ( 185 / 235 )
Branches 62.72% ( 69 / 110 )
Functions 61.7% ( 29 / 47 )
Lines 78.72% ( 185 / 235 )

Copy link
Contributor

Wazuh Core plugin code coverage (Jest) test % values
Statements 45.3% ( 400 / 883 )
Branches 41.09% ( 157 / 382 )
Functions 43.31% ( 136 / 314 )
Lines 45.48% ( 398 / 875 )

Copy link
Contributor

Main plugin code coverage (Jest) test % values
Statements 16.89% ( 5055 / 29914 )
Branches 10.32% ( 1990 / 19280 )
Functions 17.92% ( 1300 / 7251 )
Lines 17.17% ( 4945 / 28788 )

@asteriscos asteriscos merged commit fc21834 into 4.12.1 May 13, 2025
5 checks passed
@asteriscos asteriscos deleted the bug/7429-missing-command-in-macos-agent-enrollment-wizard branch May 13, 2025 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing command in macOS agent enrollment wizard
3 participants