Skip to content

Add option to dim display as much as possible on disconnect on Intel #1808

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
waydabber opened this issue May 7, 2023 · 5 comments
Closed

Add option to dim display as much as possible on disconnect on Intel #1808

waydabber opened this issue May 7, 2023 · 5 comments
Assignees
@waydabber
Labels
display connection Display connection management done All tasks are completed enhancement New feature or request Intel Related to Macs with Intel architecture released Released
Milestone
v1.4.11

Comments

@waydabber
Copy link
Owner

waydabber commented May 7, 2023 •
edited
Loading

Add an option to dim display as much as possible (using the current control method for the display) on disconnecting the display on Intel (using DDC backlight control).

If Settings/Displays/"Turn off display backlight when combined brightness is set to zero" is enabled, backlight should be turned off via DDC.
@waydabber waydabber added enhancement New feature or request Intel Related to Macs with Intel architecture display connection Display connection management labels May 7, 2023
@waydabber waydabber self-assigned this May 7, 2023
@waydabber waydabber mentioned this issue May 7, 2023
Closed
@waydabber waydabber added in progress Implementing internal pre-release Enable internal pre-releases under Settings/Applications/Updates labels May 7, 2023
@waydabber waydabber added this to the v1.4.11 milestone May 10, 2023
@waydabber
Copy link
Owner Author

Screenshot 2023-05-10 at 18 42 16

@waydabber
Copy link
Owner Author

This option will show on Intel and will be enabled by default.

@waydabber
Copy link
Owner Author

Ok, this now seems to work nicely on v2.x. But now have to implement on 1.4.x as well.

Note: things diverged quite a bit between the two versions (v1.4.x and v2.x) - adding features to both won't be sustainable on the long run, but since 1.4.x is the one with compatibility with older Intel Macs and macOS versions, it is important to port the Intel disconnect feature back to this version and make the extra effort.

@waydabber waydabber added done All tasks are completed and removed in progress Implementing labels May 11, 2023
@waydabber
Copy link
Owner Author

Backported to v1.4.x.

@waydabber waydabber added released Released and removed internal pre-release Enable internal pre-releases under Settings/Applications/Updates labels May 12, 2023
@waydabber
Copy link
Owner Author

The backlight of the internal display is by default turned off by the feature on Intel, but the external display is only dimmed as much as possible and not put to sleep (as with Apple Silicon macs). Some displays support turning off their backlight via DDC - to use this feature when disconnecting the display, you need to enable Turn off display backlight when combined brightness is set to zero under Settings/Displays//Show advanced control settings:

Screenshot 2023-05-12 at 18 29 42

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@waydabber waydabber

Labels
display connection Display connection management done All tasks are completed enhancement New feature or request Intel Related to Macs with Intel architecture released Released
Projects
None yet
Milestone
v1.4.11
Development

No branches or pull requests
1 participant
@waydabber