Fix MacOS tools alias error #426
Conversation
| ```sh | ||
| brew install coreutils # contains grealpath | ||
| brew install gpatch | ||
| brew install diffutils |
There was a problem hiding this comment.
What about the diffutils? I believe they should also be installed with brew to get the correct behavior?
What about grealpath?
There was a problem hiding this comment.
I should return install code block. It was part of aliases so I automatically discarded it.
Above is still mentioned to install those deps though.
There was a problem hiding this comment.
Just to double check that realpath alias is no longer needed?
There was a problem hiding this comment.
I tested this without any aliases and it worked. Aliases don't work in shell scripts anyway. That is the reason this PR started:
Aliases and functions do not propagate to shell scripts
There was a problem hiding this comment.
Ah true, great then 👍 I wanted to be extra safe since I didn't conclude that it's okay to delete it myself.
Fixes problems caused by:
Old alias instructions are removed, instead we "alias" the command inside of the script itself.
The script exits if there is no
gpatchon MacOS.Fixes #416