Update S3 upload to validate file size and use POST #385
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sodic
approved these changes
Feb 25, 2025
|
I've tested it 👍 We should update the same docs as you did, after we merge #384 |
vincanger
approved these changes
Feb 26, 2025
infomiho
commented
Feb 28, 2025
| @@ -105,8 +105,6 @@ Now we need to change some permissions on the bucket to allow for file uploads f | |||
| } | |||
| ] | |||
| ``` | |||
| As an example, here are the CORS permissions for this site - https://opensaas.sh: | |||
| <Image src={corsExample} alt="cors-example" loading="lazy" /> | |||
There was a problem hiding this comment.
@sodic I've deleted this image since it's just repeating what the code block says and it's easier so we don't have to retake screenshots every time we update the code block
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It uses the
createPresignedPostto create an upload URL which can have limit the file upload file. It sets thecontent-length-rangeto be of maximumMAX_FILE_SIZE_BYTESwhich is the same value we use on the client.