remove newsletter stuff #383
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
infomiho
reviewed
Feb 25, 2025
opensaas-sh/app_diff/deletions
Outdated
| @@ -2,6 +2,7 @@ src/client/static/avatar-placeholder.webp | |||
| src/client/static/da-boi.webp | |||
| src/client/static/open-saas-banner.webp | |||
| src/landing-page/logos/SalesforceLogo.tsx | |||
| src/newsletter/sendNewsletter.ts | |||
There was a problem hiding this comment.
How come this is in a list of deleted files in opensaas.sh when this file no longer exists in the template? Do you maybe need to regenerated the diffs?
There was a problem hiding this comment.
yeah weird.
I re-patched and re-diffed. Should be ok now :)
infomiho
approved these changes
Feb 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Removes the newsletter section of the app, which was only partially implemented. It's purpose was to show how to use email sending and Wasp jobs, but we do this elsewhere in the app, so BYE BYE.
Contributor Checklist