-
Notifications
You must be signed in to change notification settings - Fork 98
docs(weave): Add documentation for our MCP integration #4261
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Preview this PR with FeatureBee: https://beta.wandb.ai/?betaVersion=cfc9b6a3837930818b394774e9bca3858aa6b333 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Content looks good, just needs to be re-ordered so that the code it more visibile.
Also add prettier backgrounds to the images to help make them pop, this tool is easy + free: https://www.chatdb.ai/tools/image/edit/screenshot-background-gradient
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are some docs build errors occurring on this PR. When I pull and run locally, the build also fails. Investigating
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ayulockin I reviewed and made various updates in e64bc82:
- fixed build
- updated writing stuff
- renamed a few section headers
- Generally rearranged and consolidated some sections in what I thought made the most sense.
Could you please review and let me know if this looks ok? I want to make sure I didn't remove any important technical info, etc.. We can revert to previous commit / patch if need be.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
Hey @J2-D2-3PO, LGTM! |
Description
This PR adds documentation for MCP.
Testing
How was this PR tested?