Skip to content

docs(weave): Add documentation for our MCP integration #4261

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 22 commits into from
Apr 28, 2025
Merged

Conversation

ayulockin
Copy link
Member

Description

This PR adds documentation for MCP.

Testing

How was this PR tested?

@circle-job-mirror
Copy link

circle-job-mirror bot commented Apr 24, 2025

@ayulockin ayulockin marked this pull request as ready for review April 25, 2025 07:38
@ayulockin ayulockin requested review from a team as code owners April 25, 2025 07:38
Copy link
Member

@morganmcg1 morganmcg1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Content looks good, just needs to be re-ordered so that the code it more visibile.

Also add prettier backgrounds to the images to help make them pop, this tool is easy + free: https://www.chatdb.ai/tools/image/edit/screenshot-background-gradient

Copy link
Member

@morganmcg1 morganmcg1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

Copy link
Contributor

@J2-D2-3PO J2-D2-3PO left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are some docs build errors occurring on this PR. When I pull and run locally, the build also fails. Investigating

@J2-D2-3PO J2-D2-3PO self-requested a review April 25, 2025 19:21
Copy link
Contributor

@J2-D2-3PO J2-D2-3PO left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ayulockin I reviewed and made various updates in e64bc82:

  • fixed build
  • updated writing stuff
  • renamed a few section headers
  • Generally rearranged and consolidated some sections in what I thought made the most sense.

Could you please review and let me know if this looks ok? I want to make sure I didn't remove any important technical info, etc.. We can revert to previous commit / patch if need be.

@J2-D2-3PO J2-D2-3PO self-requested a review April 25, 2025 19:22
@J2-D2-3PO J2-D2-3PO requested a review from morganmcg1 April 25, 2025 19:22
Copy link
Member

@morganmcg1 morganmcg1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@ayulockin
Copy link
Member Author

Hey @J2-D2-3PO, LGTM!

@J2-D2-3PO J2-D2-3PO merged commit bbe6761 into master Apr 28, 2025
146 checks passed
@J2-D2-3PO J2-D2-3PO deleted the mcp-docs branch April 28, 2025 18:55
@github-actions github-actions bot locked and limited conversation to collaborators Apr 28, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants