fix: rename unstable_redirect and add example #931
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
rmarscher
approved these changes
Oct 3, 2024
| <Link to="/">Go to Home</Link> | ||
| </p> | ||
| <p> | ||
| <button onClick={() => jump()}>Jump to random page</button> |
There was a problem hiding this comment.
😍 server functions are fun
tylersayshi
reviewed
Oct 3, 2024
packages/waku/src/router/client.ts
Outdated
Comment on lines
525
to
531
| setTimeout(() => { | ||
| // HACK we need to wait a tick for React to start rendering. | ||
| // FIXME It doesn't feel ideal. Hope to find a better solution. | ||
| routerData[1]?.forEach((listener) => | ||
| listener(pathname, searchParamsString), | ||
| ); | ||
| }); |
There was a problem hiding this comment.
Would startTransition from react be less of a hack?
There was a problem hiding this comment.
Unfortunately, not. I'm not sure if it's React issue or Waku issue. Probably, the latter.
Meanwhile, I used another hack 3fedc84.
There was a problem hiding this comment.
Ahhh, unfortunately, this causes a flicker when moving to a new page. Let me revert it and open a new issue with jump case.
dai-shi
added a commit
that referenced
this pull request
Oct 4, 2024
This was referenced Oct 4, 2024
dai-shi
added a commit
that referenced
this pull request
Oct 4, 2024
yokos2
added a commit
to yokos2/react-yoko-portfolio
that referenced
this pull request
Feb 8, 2025
HondaKazuhiro
added a commit
to HondaKazuhiro/waku
that referenced
this pull request
Feb 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#927 (reply in thread)